Skip to content

Commit

Permalink
Hack github.com/google/certificate-transparency-go/x509 overriding-t-…
Browse files Browse the repository at this point in the history
…option error

Summary:
There's two issues and I don't have a better idea than ignore both (see D66772320 for context)

First one
```

Action failed: fbcode//third-party-go/vendor/github.com/google/certificate-transparency-go/x509:x509 (c_compile cgo_gen_tmp/root_cgo_darwin.cgo2.c (pic))
Remote command returned non-zero exit code 1
Reproduce locally: `frecli cas download-action 5ab60a491573966965f5001689a594bcac77a605b4e359a509fa6993213141de:145`
stdout:
stderr:
clang: error: overriding '-mmacosx-version-min=10.10' option with '-target x86_64-apple-macosx10.15' [-Werror,-Woverriding-t-option]
Buck UI: https://www.internalfb.com/buck2/b038884c-ce9d-48e0-b323-f831aaf0c8d1
Network: Up: 458KiB  Down: 24MiB  (reSessionID-cf79fe1a-d001-4200-b13f-d05e7f113d57)
Jobs completed: 13513. Time elapsed: 8.5s.
Cache hits: 93%. Commands: 2807 (cached: 2613, remote: 1, local: 193)
BUILD FAILED
Failed to build 'fbcode//third-party-go/vendor/github.com/google/certificate-transparency-go/x509:x509 (cfg:macos-x86_64-macosx-clang17-no-san#63ba25154b14f2dd)'
```

Ignored with -Wno-error=overriding-t-option

Second one
```
Action failed: fbcode//third-party-go/vendor/github.com/google/certificate-transparency-go/x509:x509 (c_compile cgo_gen_tmp/root_cgo_darwin.cgo2.c (pic))
Remote command returned non-zero exit code 1
Reproduce locally: `frecli cas download-action 1718c0315fc5f75e86d52eddb947c382a033dc178e3c76d097f1c3f54d5cf662:145`
stdout:
stderr:
clang: warning: overriding '-mmacosx-version-min=10.10' option with '-target x86_64-apple-macosx10.15' [-Woverriding-t-option]
clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument]
/paragon/pods/266228793/home/execution/0/119f002717074c2ca080afd7b50b7492/work/fbcode/third-party-go/vendor/github.com/google/certificate-transparency-go/x509/root_cgo_darwin.go:139:26: error: 'SecCertificateCopyNormalizedSubjectContent' is deprecated: first deprecated in macOS 10.12.4 - SecCertificateCopyNormalizedSubjectContent is deprecated. Use SecCertificateCopyNormalizedSubjectSequence instead. [-Werror,-Wdeprecated-declarations]
  139 |         CFDataRef subjectName = SecCertificateCopyNormalizedSubjectContent(cert, errRef);
      |                                 ^
buck-out/v2/gen/fbsource/09379a44da3a279d/xplat/toolchains/apple/__xcode_16.0.0_16a242d-macosx-sdk_genrule-actual__/MacOSX15.0.sdk/System/Library/Frameworks/Security.framework/Headers/SecCertificate.h:602:11: note: 'SecCertificateCopyNormalizedSubjectContent' has been explicitly marked deprecated here
  602 | CFDataRef SecCertificateCopyNormalizedSubjectContent(SecCertificateRef certificate, CFErrorRef *error)
      |           ^
/paragon/pods/266228793/home/execution/0/119f002717074c2ca080afd7b50b7492/work/fbcode/third-party-go/vendor/github.com/google/certificate-transparency-go/x509/root_cgo_darwin.go:143:25: error: 'SecCertificateCopyNormalizedIssuerContent' is deprecated: first deprecated in macOS 10.12.4 - SecCertificateCopyNormalizedIssuerContent is deprecated. Use SecCertificateCopyNormalizedIssuerSequence instead. [-Werror,-Wdeprecated-declarations]
  143 |         CFDataRef issuerName = SecCertificateCopyNormalizedIssuerContent(cert, errRef);
      |                                ^
buck-out/v2/gen/fbsource/09379a44da3a279d/xplat/toolchains/apple/__xcode_16.0.0_16a242d-macosx-sdk_genrule-actual__/MacOSX15.0.sdk/System/Library/Frameworks/Security.framework/Headers/SecCertificate.h:584:11: note: 'SecCertificateCopyNormalizedIssuerContent' has been explicitly marked deprecated here
  584 | CFDataRef SecCertificateCopyNormalizedIssuerContent(SecCertificateRef certificate, CFErrorRef *error)
      |           ^
2 errors generated.
Buck UI: https://www.internalfb.com/buck2/ce62a9a9-5442-4dc5-8f22-1973bd06973f
Network: Up: 229KiB  Down: 933KiB  (reSessionID-43002c46-5b08-45a0-9739-336eb75eb504)
Jobs completed: 1841. Time elapsed: 36.7s.
Cache hits: 82%. Commands: 381 (cached: 313, remote: 11, local: 57)
BUILD FAILED
Failed to build 'fbcode//third-party-go/vendor/github.com/google/certificate-transparency-go/x509:x509 (cfg:macos-x86_64-macosx-clang17-no-san#63ba25154b14f2dd)'
```

Ignored with -Wno-deprecated-declarations

Reviewed By: rmaz

Differential Revision: D66772320

fbshipit-source-id: 24c14274509b9b11101616dd180afa0f196f137e
  • Loading branch information
Naris Siamwalla authored and facebook-github-bot committed Dec 6, 2024
1 parent 3cdc469 commit 30d75d2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions go/cgo_builder.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ def _cxx_wrapper(ctx: AnalysisContext, own_pre: list[CPreprocessor], inherited_p
cxx_cmd = cmd_args(
c_compiler.compiler,
c_compiler.preprocessor_flags,
get_target_sdk_version_flags(ctx),
c_compiler.compiler_flags,
pre_args,
pre_include_dirs,
Expand Down

0 comments on commit 30d75d2

Please sign in to comment.