Skip to content

Commit

Permalink
fix broken xru3d tests
Browse files Browse the repository at this point in the history
Summary: This diff modifies my recently added `maybe_add_run_as_bundle_label` function to opt out of both default_run_as_bundle and the tpx.force_run_as_bundle instead of only opting out of default_run_as_bundle.

Reviewed By: bricehalder

Differential Revision: D63796604

fbshipit-source-id: e4c24f0511eb0a14bf0b9e81a297af3c678d24a5
  • Loading branch information
jrodal98 authored and facebook-github-bot committed Oct 3, 2024
1 parent dd2c6e8 commit 7b4678c
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tests/re_utils.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ def _get_re_arg(ctx: AnalysisContext) -> ReArg:
return ReArg(re_props = None, default_run_as_bundle = False)

def maybe_add_run_as_bundle_label(ctx: AnalysisContext, labels: list[str]) -> None:
if "re_ignore_force_run_as_bundle" in labels:
return
re_arg = _get_re_arg(ctx)
run_as_bundle = re_arg.default_run_as_bundle and "re_ignore_default_run_as_bundle" not in ctx.attrs.labels
if run_as_bundle or read_config("tpx", "force_run_as_bundle") == "True":
if re_arg.default_run_as_bundle or read_config("tpx", "force_run_as_bundle") == "True":
labels.extend(["run_as_bundle"])

def get_re_executors_from_props(ctx: AnalysisContext) -> ([CommandExecutorConfig, None], dict[str, CommandExecutorConfig]):
Expand Down

0 comments on commit 7b4678c

Please sign in to comment.