-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recent bugs with shim/third-party #751
Conversation
buildscript = [] | ||
|
||
[platform_fixup.'cfg(any(target_arch = "aarch64", target_arch = "loongarch64", target_arch = "mips64", target_arch = "powerpc64", target_arch = "wasm32", target_arch = "x86_64"))'] | ||
buildscript = [] | ||
rustc_flags = ['--cfg=fast_arithmetic="64"'] | ||
|
||
[platform_fixup.'cfg(not(any(target_arch = "aarch64", target_arch = "loongarch64", target_arch = "mips64", target_arch = "powerpc64", target_arch = "wasm32", target_arch = "x86_64")))'] | ||
buildscript = [] | ||
rustc_flags = ['--cfg=fast_arithmetic="32"'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the upstream build script, instead of transcribing the logic like this.
Example:
buck2/shim/third-party/rust/fixups/num-traits/fixups.toml
Lines 1 to 2 in 9beff40
[[buildscript]] | |
[buildscript.rustc_flags] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, I didn't realize thats what the syntax does
Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, have fixup script evaluate the build configuration. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files.
@dtolnay ptal |
5530e07
to
08b8b3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@dtolnay has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Summary: Observed builds at [TraceMachina/buck2](https://github.com/TraceMachina/buck2/actions/workflows/build-and-test.yml) recently broke due to inconsistencies with shim/third-party directory. `reindeer buckify` will not delete existing `Cargo.lock` and `BUCK` if they already exist. `reindeer update` might assume that `reindeer buckify` was done first. A simple and consistent way is to ensure those files are deleted before calling `reindeer` instead of assuming how `reindeer` will behave. [serde-rs](https://github.com/serde-rs/json/blob/5ebf65cc480f90714c94f82099ca9161d80cbb10/build.rs#L11) recently introduced a rustc configuration flag that has to be set.`fast_arithmetic` chooses the architecture based on `target_arch`, repeat the same in the fixup scripts. `zstd` is missing header files, most likely not caught due to stale `Cargo.lock` and `BUCK` files. X-link: facebook/buck2#751 Reviewed By: JakobDegen Differential Revision: D61753931 Pulled By: dtolnay fbshipit-source-id: 2432083b700149a24cdd9b3954d250a147403954
Observed builds at TraceMachina/buck2 recently broke due to inconsistencies with shim/third-party directory.
reindeer buckify
will not delete existingCargo.lock
andBUCK
if they already exist.reindeer update
might assume thatreindeer buckify
was done first. A simple and consistent way is to ensure those files are deleted before callingreindeer
instead of assuming howreindeer
will behave.serde-rs recently introduced a rustc configuration flag that has to be set.
fast_arithmetic
chooses the architecture based ontarget_arch
, repeat the same in the fixup scripts.zstd
is missing header files, most likely not caught due to staleCargo.lock
andBUCK
files.