Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .svg to url-loader, and update documentation? #3370

Closed
thomastvedt opened this issue Oct 31, 2017 · 2 comments
Closed

Add .svg to url-loader, and update documentation? #3370

thomastvedt opened this issue Oct 31, 2017 · 2 comments

Comments

@thomastvedt
Copy link

Is this a bug report?

No

Which terms did you search for in User Guide?

Adding .svg images

Environment

  1. node -v: v6.11.3
  2. npm -v: 3.10.10
  3. yarn --version (if you use Yarn): 1.2.1
  4. npm ls react-scripts (if you haven’t ejected): react-scripts-ts@2.6.0

In the user guide it says that:

To reduce the number of requests to the server, importing images that are less than 10,000 bytes returns a data URI instead of a path. This applies to the following file extensions: bmp, gif, jpg, jpeg, and png. SVG files are excluded due to #1153.

Bugs #1153 and #1180 are fixed. Should we add .svg to url-loader too? And update the user guide? I have a lot of small .svg files that could be a data URI?

@heyimalex
Copy link
Contributor

That issue says why it's disabled; inlining svgs breaks fragments. So it probably won't change unless you have a different solution for that case?

@thomastvedt
Copy link
Author

oh, sorry about that 🤦‍♂️

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants