Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flex attribute compile error #3978

Closed
sam019 opened this issue Feb 5, 2018 · 3 comments
Closed

flex attribute compile error #3978

sam019 opened this issue Feb 5, 2018 · 3 comments

Comments

@sam019
Copy link

sam019 commented Feb 5, 2018

Is this a bug report?

yes

Did you try recovering your dependencies?

yes

Which terms did you search for in User Guide?

Environment

  1. node -v: v9.3.0
  2. npm -v: 5.6.0
  3. yarn --version (if you use Yarn):
  4. npm ls react-scripts (if you haven’t ejected): 1.1.0

Then, specify:

  1. Operating system: macOS 10.13.2
  2. Browser and version (if relevant): Google Chrome Canary 66

Steps to Reproduce

(Write your steps here:)

  1. write this in css: flex: 1 1 0;, this mean flex-grow: 1; flex-shrink: 1; flex-basis: 0
  2. save and compile

Expected Behavior

the compiled css should be: flex: 1 1 0;

Actual Behavior

the compiled css is: flex: 1 1;

because flex: 1 1; mean flex-grow: 1; flex-shrink: 1; flex-basis: 0%; the problem is:
flex-basis: 0% not equal to flex-basis: 0, and so produce style bug

@sam019 sam019 changed the title css compile error flex attribute compile error Feb 5, 2018
@gaearon
Copy link
Contributor

gaearon commented Feb 5, 2018

because flex: 1 1; mean flex-grow: 1; flex-shrink: 1; flex-basis: 0%;

What do you base this information on? MDN claims the default value for flex-basis is 0.

https://developer.mozilla.org/en-US/docs/Web/CSS/flex

I believe the spec says the same.

@sam019
Copy link
Author

sam019 commented Feb 6, 2018

@gaearon yes, you are right. But in chrome 64.0.3282.140 (64-bit),the default value for flex-basis is 0%, I think this is a bug.
FLEX

@sam019 sam019 closed this as completed Feb 6, 2018
@gaearon
Copy link
Contributor

gaearon commented Feb 6, 2018

Please report it to Chrome 🙂

@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants