Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to create new app #570

Closed
abhinavkumar940 opened this issue Sep 4, 2016 · 6 comments
Closed

Not able to create new app #570

abhinavkumar940 opened this issue Sep 4, 2016 · 6 comments

Comments

@abhinavkumar940
Copy link

Just installed it on OSX 10.10.5

tried creating a new app by
create-react-app hello-world
got this

/usr/local/lib/node_modules/create-react-app/node_modules/path-exists/index.js:2
const fs = require('fs');
^^^^^
SyntaxError: Use of const in strict mode.
at Module._compile (module.js:439:25)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at Object. (/usr/local/lib/node_modules/create-react-app/index.js:44:18)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)

@gaearon
Copy link
Contributor

gaearon commented Sep 4, 2016

Can you please specify your Node version?

@gaearon
Copy link
Contributor

gaearon commented Sep 4, 2016

As noted in README we only support Node 4 and higher. Please update your Node version, the project won't work without it.

We should however make sure that CLI doesn't just throw, and print a descriptive error on earlier versions instead. I think this is a regression because we added a dependency on path-exists which seems to need Node 4 itself. So we need to replace this dependency in global CLI with something that works on Node 4 so we can print a proper warning.

@sotojuan
Copy link

sotojuan commented Sep 4, 2016

So we need to replace this dependency in global CLI with something that works on Node 4 so we can print a proper warning.

Did you mean "with something that works on Node 4 and below"?

If so, path-exists is a very simple module that we can probably write ourselves in ES5 and just put it somewhere as a file to require, if that makes sense. We don't have to worry about the promise or any async methods as CRA doesn't use them.

@gaearon
Copy link
Contributor

gaearon commented Sep 4, 2016

Sounds good, yes this is what I meant.

@abhinavkumar940
Copy link
Author

That was indeed the issue. Upgraded to 6.5 and it now works.
Thank you for the prompt response, guys.

@gaearon
Copy link
Contributor

gaearon commented Sep 4, 2016

@sotojuan Would you be interested in sending a PR to make CLI work on earlier nodes, at least up to the point where it detects the version?

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants