Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change template project to functional rather than class-based component. #6558

Closed
nonzeronucleus opened this issue Mar 2, 2019 · 1 comment

Comments

@nonzeronucleus
Copy link

The template project for create-react-app still uses React.Component in App.js.

Given that hooks are looking to deprecate class-based components, now would seem a good time to turn it into a functional component.

It look like it's a simple enough change. But before I do it, I wanted to make sure that no one else was doing this, and that there wasn't a good reason to keep App.js as class-based.

@iansu
Copy link
Contributor

iansu commented Mar 2, 2019

There's an existing PR that does exactly this: #6451

@iansu iansu closed this as completed Mar 2, 2019
@stale stale bot added the stale label Apr 1, 2019
@iansu iansu removed the stale label Apr 2, 2019
@facebook facebook deleted a comment from stale bot Apr 2, 2019
@lock lock bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants