Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create-react-app broken for Node.js v0.10 #6940

Closed
tobiasbueschel opened this issue Apr 28, 2019 · 2 comments · Fixed by #6941
Closed

Create-react-app broken for Node.js v0.10 #6940

tobiasbueschel opened this issue Apr 28, 2019 · 2 comments · Fixed by #6941

Comments

@tobiasbueschel
Copy link
Contributor

Is this a bug report?

Yes, I've noticed that create-react-app currently breaks on Node v.0.10 due to its usage of chalk.

In 2017, @einarlove submitted a PR that upgraded Chalk #2847 and @gaearon pushed a fix to the same branch as CI was breaking: 3e688df which removed chalk as a dependency from packages/create-react-app/index.js so that users get a sensible error message when their Node.js version is not supported.

Eventually, the PR was closed and the fix hasn't made it into the repo yet.

Did you try recovering your dependencies?

Yes.

Which terms did you search for in User Guide?

See above for more details on my research for this issue.

Environment

This has been tested in a Docker environment running Node v0.10. Please see below for steps to reproduce the error.

Steps to Reproduce

  1. docker run -it node:0.10 bash
  2. npm install -g create-react-app
  3. create-react-app my-app

Expected Behavior

root@a3b41c9b59c3:/# create-react-app my-app
You are running Node 0.10.48.
Create React App requires Node 8 or higher.
Please update your version of Node.

Actual Behavior

root@a3b41c9b59c3:/# create-react-app my-app

/usr/local/lib/node_modules/create-react-app/node_modules/chalk/index.js:2
const escapeStringRegexp = require('escape-string-regexp');
^^^^^
SyntaxError: Use of const in strict mode.
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/usr/local/lib/node_modules/create-react-app/index.js:39:13)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)

Reproducible Demo

n/a

@stale
Copy link

stale bot commented May 28, 2019

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label May 28, 2019
@tobiasbueschel
Copy link
Contributor Author

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

This issue is still relevant - I've created a PR to fix it which is still pending! 🙏

@stale stale bot removed the stale label May 28, 2019
@lock lock bot locked and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant