Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make react-dev-utils/webpackHotDevClient work with webpack 2 #839

Closed
michalkvasnicak opened this issue Oct 4, 2016 · 2 comments
Closed

Comments

@michalkvasnicak
Copy link
Contributor

I am working on a tool similar to create-react-app but plugin based with webpack 2 support. I want to use react-dev-utils as a dependency because I need webpackHotDevClient but it's not compatible with webpack 2.

Fix is simple so I am asking if someone is working on this or should I create a PR?

@michalkvasnicak
Copy link
Contributor Author

To make it work with webpack 2, we need to check if module.hot.check is returning a promise and use callback in promise.

@gaearon
Copy link
Contributor

gaearon commented Oct 4, 2016

I’d take a PR adding support for Webpack 2 there.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants