-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server still runs in the background #932
Comments
Hi @chaseWillden ,
|
@dvkndn
One important thing to note is I am using the Cygwin terminal. |
oh for the last question, I mean do you able to reproduce the issue with a new create-react-app project? Just after generated? Hm.. have you ever try to see if it works in any other terminal? |
Yes, it happens with new projects. Even when I update the create-react-app on my computer. I'll check other terminals. |
Can you try debugging why this happens? |
Happens for me as well in the cygwin terminal (mintty 2.7.1) on windows 7. I created fresh project and only one more folder with component. Ctrl+C stops the script but nothing happens with the node server, I have to kill node through task manager (closing cygwin almost never works). https://gyazo.com/5038db711e66a2eca13ccec0abef21c1 I don't know how to debug the script btw, any pointer to some tutorial or something would be helpful. It seems to be running just fine in PowerShell though. EDIT: |
This might be a bug in |
Just dropping a note, I've noticed runaway node processes on on macOS too. I'll try to keep an eye out for the cause in the future. |
I also noticed this. We should fix it. |
Guessing #1753 solves this? |
Maybe. |
I have the same issue mac OS node v7.6.0 npm 4.1.2 |
Same issue as @ericjasonthomas |
Hopefully this is fixed by #2246. |
|
This is concerning behavior -- I can't seem to stop it and it's taken over port 8888. Restarted twice now and it doesn't stop even after restart. I don't see any processes running node and there aren't any startup scripts that stand out that would be causing it. Edit: It appears that its some form of progressive webapp enhancement that keeps the app in offline storage. I stopped the node process and then went into Inspector -> Applications -> Clear Storage, cleared everything, now the app goes away. It's not loading the offline app now, which is likely the source of the issue. |
Yes, as noted both in migration notes for 1.0 and in User Guide, the default template now includes a service worker that ensures the app can be cached for offline use (and, importantly, near-instant recurrent visits). The User Guide also includes instructions to opt out (you can remove the service work registration call from |
@gaearon I tried removing registerServiceWorker() from index.js, but the process still persists after ctrl-c or ctrl-z. (I'm running npm 3.10.10 on Cygwin.) Any other ideas? It's really annoying to have to kill the process in task manager every time. |
I can confirm this as happening for me on Windows 10. I've been working on several apps bootstrapped with CRA. Some ejected, some not. Some with registerServiceWorker, some not. I've become accustomed to pressing It might be worth noting that this only happens if I'm using Git Bash. If I run the process in my IDE's shell(VS Code) pressing |
This also occurs for me. Using Cygwin on Windows 10. Just killed via Task Manager like above user. |
This issue persists when using Git Bash on Windows 10 (multiple different machines). Can we please re-open? |
As @joelwross said, I also observed same issue on Windows 10 with Git Bash, when Ctrl+C terminate the job, the port is still occupied and website is accessible. (I'm using the demo page). CMD doesn't have the problem. |
Observed same issue 👍 |
I'm also having this problem. |
Having issue after updating to recent CRA |
Same issue, Windows 7, Git Bash. |
Possibly unrelated, but
|
@gaearon I'm using react-scripts 2.1.1 and this issue is still present on Windows 10 using vscode terminal. |
@gaearon still seeing this in cygwin, Windows 10, react-scripts 2.1.1. |
still having this problem |
Description
When I run
npm start
, then I kill the appctrl+c
, the NodeJs server still runs as a task in the background.Expected behavior
The process should be fully stopped.
Environment
Run these commands in the project folder and fill in their results:
npm ls react-scripts
(if you haven’t ejected):node -v
: 6.4.0npm -v
: 3.10.3Then, specify:
The text was updated successfully, but these errors were encountered: