Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understanding: babel-preset-react-app #989

Closed
sathishsoundharajan opened this issue Oct 30, 2016 · 2 comments
Closed

Understanding: babel-preset-react-app #989

sathishsoundharajan opened this issue Oct 30, 2016 · 2 comments

Comments

@sathishsoundharajan
Copy link

Hi,
Just for understanding purpose to check either i misunderstood or a bug.

In babel-preset-react-app package between this lines (https://github.com/facebookincubator/create-react-app/blob/master/packages/babel-preset-react-app/index.js#L56-L63) you are adding two react-plugins for development/test mode.

Now lines (https://github.com/facebookincubator/create-react-app/blob/master/packages/babel-preset-react-app/index.js#L80-L88) will add full babel-react-preset itself which contains those two packages as dependencies

image

Now can help me understand why we are adding separately once again on top ?

@fson
Copy link
Contributor

fson commented Oct 30, 2016

Thanks for the question @bboysathish! babel-preset-react does have those plugins as dependencies, but if you look at the source code, it does not enable them at the moment.

Here's a discussion in the Babel repository about adding them to the preset: babel/babel#4702

@fson fson closed this as completed Oct 30, 2016
@sathishsoundharajan
Copy link
Author

@fson Thanks for the info. Made a pull request to explain.

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants