WP5 - Update fork-ts-checker-webpack-plugin [DRAFT] #10004
Closed
+47
−138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * [hook rename](TypeStrong/fork-ts-checker-webpack-plugin#490) * [include/exclude](TypeStrong/fork-ts-checker-webpack-plugin#450) and [issue options](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#issues-options) * [release notes 5.0.0](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/releases/tag/v5.0.0)
raix
requested review from
ianschmitz,
iansu,
mrmckeb and
petetnt
as code owners
raix
changed the title
piotr-oles
suggested changes
Nov 4, 2020
|
https://github.com/TypeStrong/fork-ts-checker-webpack-plugin v6.0.1 is now out, might be worth bumping to that |
We should raise that with them if it's doing that. It shouldn't be |
raix
commented
Dec 5, 2020
raix
commented
Dec 5, 2020
mbarrien
added a commit
to chanzuckerberg/czgenepi
that referenced
this pull request
Feb 10, 2021
facebook/create-react-app#10004 makes changes to react-dev-utils that are not present in the currently released version pulled down by npm. Revert and reapply once new version of react-dev-utils is released (probably at same time as create-react-app releases Webpack 5 compatible version).
raix
changed the title
|
Cherry picked into the wp5 branch - closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update fork-ts-checker-webpack-plugin@5.2.1
References:
Part of making way for Webpack 5 #9994
yarn docker:e2e --test-suite simplenot yet tested but done manual QA locally*cc. @piotr-oles regarding your comment maybe you can help review this one?
Potential breaking changes if anyone externally depends on
react-dev-utils:react-dev-utils/typescriptFormatter- it's removed as it's no longer needed in the CRA projectreact-dev-utils/WebpackDevServerUtils-createCompilerno longer use argumentsdevSocketortscCompileOnErrorRemoved to keep the code base small and clean