Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs before milestone release 4.0.2 #10227

Closed
wants to merge 1 commit into from

Conversation

JackHowa
Copy link

@JackHowa JackHowa commented Dec 9, 2020

Encountered this issue after following instructions. saw issue sass/node-sass#3016 and recent fix #9988

Encountered this issue after following instructions. saw issue sass/node-sass#3016 and recent fix facebook#9988
@facebook-github-bot
Copy link

Hi @JackHowa!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@JackHowa
Copy link
Author

JackHowa commented Dec 9, 2020

signed cla

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JackHowa
Copy link
Author

@mrmckeb @ianschmitz should I close this? as it will be fixed by 4.0.2 release https://github.com/facebook/create-react-app/milestone/79

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JackHowa
Copy link
Author

not sure if this is a priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants