Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't the const braces be removed to make it work properly? #10622

Closed
wants to merge 1 commit into from
Closed

Shouldn't the const braces be removed to make it work properly? #10622

wants to merge 1 commit into from

Conversation

Seokkitdo
Copy link

@Seokkitdo Seokkitdo commented Feb 28, 2021

It works fine after removing the braces.

After removing curly braces in works well
Works well2
Works well

If I run the command(yarn start) without removing the curly braces I get the following output
Works bad

@facebook-github-bot
Copy link

Hi @Seokkitdo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@petetnt
Copy link
Contributor

petetnt commented Mar 1, 2021

Hi @Seokkitdo!

The documentation uses { createHttpProxy }

https://github.com/chimurai/http-proxy-middleware

and the code exports it as an function https://github.com/chimurai/http-proxy-middleware/blob/master/src/index.ts

Can you confirm the version of http-proxy-middleware you are using?

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Seokkitdo
Copy link
Author

Can you confirm the version of http-proxy-middleware you are using?

I used the "http-proxy-middleware": "^1.0.6",
I've entered that link before. I saw it in an article that was solved by someone who was having the same problem.
Here's the link https://www.reddit.com/r/reactjs/comments/jzoo3y/createproxymiddleware_is_not_a_function_how_can_i/

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants