fix crash of wds when trying to follow emacs lock files by ignoring them

[zalox]

Hi,

The Webpack development server crashes when it tries to follow emacs lock files.

See #9056 for a more detailed description of the issue.

The default ignore options from watchpack (chokidar?) was changed at some point. This restores previous behavior of this package.

[facebook-github-bot]

Hi @zalox!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[ericprud]

Anyone know why Azure barfed all over this? If it was a coincidential but, would those messages be cleared by @zalox pushing a trivial whitespace change?

[zalox]

Hello,

I just rebased my branch top of the current master.

[zalox]

Anyone know why Azure barfed all over this? If it was a coincidential but, would those messages be cleared by @zalox pushing a trivial whitespace change?

The tests were bad. They assumed that the ignoredFiles would return a regex. After this fix, it returned an array of regexes instead. See the two last commits.

[stale]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[ericprud]

@zalox , as far as you know, is this patch still necessary? If you merge main, do the tests still pass?
If yes on both, anyone know of any other blockers for merging?

[Invertisment]

I think this is where monorepos and monoliths fail. If there is a problem and nobody exposes a way to configure it then people need to go through hoops to fix it. If that's even possible at all.

This repo has 1.2K of open issues. There is no way this is ever going to merged. Let's keep bumping it if it's the only way to provide any signalling.

https://drewdevault.com/2021/11/16/Cash-for-leftpad.html

[Invertisment]

#!/bin/bash
set -e

# Fixes emacs file watcher temp file crashes
# Run from you project root

cd ./node_modules/react-dev-utils/
rm -vf ignoredFiles.js
wget 'https://raw.githubusercontent.com/facebook/create-react-app/a3dd649530f4c0c305fc183842399c9d36ecf97f/packages/react-dev-utils/ignoredFiles.js'

echo OK

[zalox]

After a bit of investigation I figured out that the issue was fixed upstream.
paulmillr/chokidar#1010
https://github.com/paulmillr/chokidar/blob/master/.github/full_changelog.md

Would it be productive to merge this anyways for the users running an old version of chokidar, to somehow pick this up as a minor update for this package? (Not completely sure how packages are resolved with npm/yarn)