Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to @babel/eslint-parser #10761

Merged
merged 10 commits into from
Jul 14, 2021
Merged

chore: migrate to @babel/eslint-parser #10761

merged 10 commits into from
Jul 14, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 29, 2021

Fixes #10636

I am not familiar with the codebase, let me know I misses something. Thanks!

ianschmitz
ianschmitz reviewed Mar 31, 2021
View reviewed changes
Copy link
Contributor

@ianschmitz ianschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JLHwung !

packages/eslint-config-react-app/base.js Outdated Show resolved Hide resolved
packages/eslint-config-react-app/package.json Show resolved Hide resolved
@ianschmitz ianschmitz added this to the 4.0.4 milestone Mar 31, 2021
@iansu iansu mentioned this pull request Mar 31, 2021
Closed
21 tasks
@JLHwung JLHwung force-pushed the switch-to-babel-eslint-parser branch from ed6430c to 29ca1b2 Compare March 31, 2021 19:05
@ljosberinn ljosberinn mentioned this pull request Apr 21, 2021
Open
@JLHwung JLHwung force-pushed the switch-to-babel-eslint-parser branch from 5a2da07 to 4afd4a6 Compare April 22, 2021 18:37
@JLHwung
Copy link
Contributor Author

JLHwung commented Apr 22, 2021

The CI reports that react-app can not be loaded by eslint, likely because @babel/eslint-parser is not provided in certain e2e fixture package.json. However I don't know where are these package.json, help will be appreciated.

/cc @ianschmitz

@karlhorky karlhorky mentioned this pull request May 11, 2021
Closed
@karlhorky
Copy link

Is it maybe having to update the yarn.lock.cached file?

https://github.com/JLHwung/create-react-app/blob/f7109764702dcd376c39c25cc9cadb145472f4f4/packages/create-react-app/yarn.lock.cached#L2431-L2441

@karlhorky karlhorky mentioned this pull request May 11, 2021
Closed
@JLHwung JLHwung force-pushed the switch-to-babel-eslint-parser branch from c50ef6b to 3d18c0a Compare May 14, 2021 14:23
@mrmckeb mrmckeb self-assigned this Jun 11, 2021
@mrnossiom mrnossiom mentioned this pull request Jun 12, 2021
Closed
@rawanst rawanst mentioned this pull request Sep 26, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 26, 2024
Open
@rawanst rawanst mentioned this pull request Sep 27, 2024
Open
@Hiranyape Hiranyape mentioned this pull request Sep 27, 2024
Open
This was referenced Sep 27, 2024
Open
Open
@rawanst rawanst mentioned this pull request Sep 28, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Merged
@rawanst rawanst mentioned this pull request Oct 1, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 1, 2024
Open
@rawanst rawanst mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 3, 2024
Open
@SanielDev SanielDev mentioned this pull request Oct 3, 2024
Open
@rawanst rawanst mentioned this pull request Oct 4, 2024
Open
This was referenced Oct 4, 2024
Open
Open
@SanielDev SanielDev mentioned this pull request Oct 6, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 15, 2024
Open
@Laurry-gee Laurry-gee mentioned this pull request Oct 21, 2024
Open
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 23, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Oct 28, 2024
Open
@rawanst rawanst mentioned this pull request Oct 29, 2024
Open
@patrickrizzardi patrickrizzardi mentioned this pull request Oct 31, 2024
Open
@barunslick barunslick mentioned this pull request Oct 31, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Nov 5, 2024
Open
@rawanst rawanst mentioned this pull request Nov 5, 2024
Open
@GregBrimble GregBrimble mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaicataldo kaicataldo kaicataldo left review comments

@ianschmitz ianschmitz ianschmitz left review comments

@mrmckeb mrmckeb mrmckeb approved these changes

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

Assignees

@mrmckeb mrmckeb

Labels
CLA Signed tag: breaking change tag: underlying tools
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

[Package Update] Switch from babel-eslint to @babel/eslint-parser to get latests fixes
10 participants
@JLHwung @karlhorky @mrmckeb @iansu @FontEndArt @ryota-murakami @devinrhode2 @ianschmitz @kaicataldo @facebook-github-bot