Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support typescript aliased imports #10971

Closed
wants to merge 1 commit into from
Closed

support typescript aliased imports #10971

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 16, 2021

Way I verified

  1. create a project via CRA
  2. change the code in node_modules
  3. add paths to tsconfig
  4. add some components use aliased import.

@ghost ghost requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners May 16, 2021 16:30
@facebook-github-bot
Copy link

Hi @arnoldcui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ghost
Copy link
Author

ghost commented May 16, 2021

relate to #10911 #10882 #10813

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@mikew
Copy link

mikew commented May 19, 2021

These paths also need to be mapped in jest. And since CRA already has a concept of webpack + jest module aliasing, it's possible to implement them in modules.js:

https://github.com/mikew/create-react-app/blob/48df474dd00d39ad28a836fd55311ab695465045/packages/react-scripts/config/modules.js#L62-L93

and

https://github.com/mikew/create-react-app/blob/48df474dd00d39ad28a836fd55311ab695465045/packages/react-scripts/config/modules.js#L95-L108

(This is a fork that ditches babel and only uses TS, and with that there's a lot of accommodations that don't need to be made.)

@ghost ghost closed this May 21, 2021
@ghost ghost reopened this May 21, 2021
@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Jun 26, 2021
@ghost ghost closed this Jul 5, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants