-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix integration test teardown / cleanup and missing yarn installation #11686
Merged
iansu
merged 30 commits into
facebook:main
from
raix:fix_integration_tests_teardown_and_cleanup
Dec 1, 2021
Merged
[WIP] Fix integration test teardown / cleanup and missing yarn installation #11686
iansu
merged 30 commits into
facebook:main
from
raix:fix_integration_tests_teardown_and_cleanup
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raix
changed the title
Fix integration test teardown / cleanup
Fix integration test teardown / cleanup and missing yarn installation
Nov 27, 2021
raix
changed the title
Fix integration test teardown / cleanup and missing yarn installation
[WIP] Fix integration test teardown / cleanup and missing yarn installation
Nov 28, 2021
This reverts commit 02fff39.
This was referenced Sep 27, 2024
This was referenced Oct 2, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests and update execa:
npm i -g yarn
in github action for integration testsFindings:
cc @iansu & @mrmckeb (We should likely squash this one if merging...)