-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update resolve-url-loader@^5.0.0 (with PostCSS v8) to avoid conflicts #12741
base: main
Are you sure you want to change the base?
Conversation
Latest version upgrades to PostCSS@8, avoiding conflicts with other packages that depend on the newer version, e.g. Storybook.
Hi @pushred! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
The pipeline failures seem to be unavailable. What was breaking with this change. I'm running into the same problems and am looking for a solution for the override that @pushred mentioned. Is there a way to rerun these failing checks so that we can get more information? |
any updates on this ? 🤔 |
Any update on merging this PR? We are receiving the same error in audit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update me when completed
This upgrades to the latest version of resolve-url-loader which itself upgrades to PostCSS@8. I have been encountering version conflicts related to this dependency and others that also depend on PostCSS that block CRA Webpack builds with this error:
The only usage of resolve-url-loader in react-scripts is requiring it in the Webpack config, so this upgrade is straightforward and in my testing causes no issue with the dev server or building for production.
I reported more details about the conflict here, including a reproduction:
storybookjs/storybook#19218
Currently I am working around this with npm v8's overrides feature.