Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proxy url starts with http:// or https:// #1890

Merged
merged 2 commits into from
Apr 15, 2017
Merged

Ensure proxy url starts with http:// or https:// #1890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3069fc1
Test that proxy url specified starts with http:// or https://
bunshar Mar 24, 2017
d2a16f6
Update addWebpackMiddleware.js
Timer Apr 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/react-scripts/scripts/utils/addWebpackMiddleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ module.exports = function addWebpackMiddleware(devServer) {
)
);
process.exit(1);
// Test that proxy url specified starts with http:// or https://
} else if (!/^http(s)?:\/\//.test(proxy)) {
console.log(
chalk.red(
'When "proxy" is specified in package.json it must start with either http:// or https://'
)
);
process.exit(1);
}

// Otherwise, if proxy is specified, we will let it handle any request.
Expand Down