Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshotResolver to the supported Jest config variables #7494

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

akuji1993
Copy link

@akuji1993 akuji1993 commented Aug 9, 2019

Fixes #6532.

by adding snapshotResolver to the supported Jest variables.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@bugzpodder bugzpodder added this to the 3.x milestone Aug 11, 2019
@philwindsor
Copy link

Is this likely to be merged any time soon?

@bigfoot31
Copy link

For those still waiting for the pull request to be accepted, you can use CRACO configuration to bypass create-react-app restrictions.

// snapshotResolver.js
module.exports = {
    testPathForConsistencyCheck: "src/views/hoc/pagination.test.tsx",
    resolveSnapshotPath: (testPath, snapshotExtension) =>
        testPath + snapshotExtension,
    resolveTestPath: (snapshotFilePath, snapshotExtension) =>
        snapshotFilePath.slice(0, -snapshotExtension.length),
};
// craco.config.js
module.exports = {
	jest: {
		configure: {
			snapshotResolver: "./snapshotResolver.js",
		},
	},
}

@ksk385
Copy link

ksk385 commented Mar 4, 2021

Whats the latest on this? Would be really useful to have this! Thanks!

@jslmariano
Copy link

Also waiting for this one :)

@iammary
Copy link

iammary commented Mar 15, 2022

For those still waiting for the pull request to be accepted, you can use CRACO configuration to bypass create-react-app restrictions.

// snapshotResolver.js
module.exports = {
    testPathForConsistencyCheck: "src/views/hoc/pagination.test.tsx",
    resolveSnapshotPath: (testPath, snapshotExtension) =>
        testPath + snapshotExtension,
    resolveTestPath: (snapshotFilePath, snapshotExtension) =>
        snapshotFilePath.slice(0, -snapshotExtension.length),
};
// craco.config.js
module.exports = {
	jest: {
		configure: {
			snapshotResolver: "./snapshotResolver.js",
		},
	},
}

thank you craco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jest configuration for snapshotresolver
10 participants