-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added snapshotResolver to the supported Jest config variables #7494
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Is this likely to be merged any time soon? |
For those still waiting for the pull request to be accepted, you can use CRACO configuration to bypass create-react-app restrictions. // snapshotResolver.js
module.exports = {
testPathForConsistencyCheck: "src/views/hoc/pagination.test.tsx",
resolveSnapshotPath: (testPath, snapshotExtension) =>
testPath + snapshotExtension,
resolveTestPath: (snapshotFilePath, snapshotExtension) =>
snapshotFilePath.slice(0, -snapshotExtension.length),
}; // craco.config.js
module.exports = {
jest: {
configure: {
snapshotResolver: "./snapshotResolver.js",
},
},
} |
Whats the latest on this? Would be really useful to have this! Thanks! |
Also waiting for this one :) |
thank you craco! |
Fixes #6532.
by adding
snapshotResolver
to the supported Jest variables.