Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terser-webpack-plugin version #9470

Closed
wants to merge 3 commits into from
Closed

Update terser-webpack-plugin version #9470

wants to merge 3 commits into from

Conversation

portexe
Copy link

@portexe portexe commented Aug 11, 2020

Older versions of terser-webpack-plugin are using a highly vulnerable version of serialize-javascript. In order to fix this, we need to update the terser-webpack-plugin which has now addressed this vulnerability.

More info on the vulnerability located here

Screenshot:

Vulnerability

@facebook-github-bot
Copy link

Hi @portexe!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@portexe
Copy link
Author

portexe commented Aug 11, 2020

I just agreed to the CLA so that will check will need to be re-started.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

1 similar comment
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ajdaniel
Copy link

It will be nice to have this and release it

@gtlambert
Copy link

Hoping to have this one merged!

@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2020

As explained in #9469 (comment), there is no actual vulnerability here.

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do a major version bump here. You need to work with terser-webpack-plugin to get them to release 3.x patch with this change. Then we can bump to that.

@portexe
Copy link
Author

portexe commented Aug 12, 2020

@gaearon it appears version 3.1.0 of terser-webpack-plugin contains the update that we want. I just updated the PR.

@portexe portexe requested a review from gaearon August 12, 2020 16:47
@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2020

Hmm. Actually this doesn't make sense either.

3.0.7 which we use on master already has the fix.

https://unpkg.com/browse/terser-webpack-plugin@3.0.7/package.json
https://www.npmjs.com/advisories/1548

So what we need to do is update the version used by react-scripts@3 today.

@gaearon gaearon closed this Aug 12, 2020
@gaearon
Copy link
Contributor

gaearon commented Aug 12, 2020

(I'll do this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants