Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add] adjust webpack config feature #9535

Closed
wants to merge 1 commit into from
Closed

[add] adjust webpack config feature #9535

wants to merge 1 commit into from

Conversation

hakobpogh
Copy link

For testing, I've installed react-scripts and react-dev-utils from my local copy of the code.

This change is adding a small feature which will let users to not eject from react-scripts for just a tiny webpack modification. In my case, I needed to change the config.target only and I didn't want to get rid of react-scripts for that.

I hope we can discuss the way you want this and we can have it in the next release :)

@facebook-github-bot
Copy link

Hi @hakobpogh!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@hakobpogh
Copy link
Author

@iansu @mrmckeb @ianschmitz @petetnt please review my PR. The failed pipelines are not from me because they're related to the parts I haven't changed. They're all throwing the following error: Module not found: You attempted to import /home/vsts/work/1/create-react-app/packages/react-dev-utils/refreshOverlayInterop.js which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.

@notaphplover
Copy link

Maybe those test fails are related to #9738

@hakobpogh
Copy link
Author

When I was recently ejecting React, I found this:

NOTE: Create React App 2+ supports TypeScript, Sass, CSS Modules and more without ejecting: https://reactjs.org/blog/2018/10/01/create-react-app-v2.html

The feature I'm suggesting is just going to help with this... People will not eject for the small issues, but instead, they will use this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants