fix: resolve new JSX transform issues #9788

mrmckeb · 2020-10-12T16:34:40Z

This PR resolves two issues with CRAv4 and React's new JSX transform - originally implemented in #9645.

The configuration has been moved to the Babel config, which means it will now work with Jest.
Conflicting ESLint rules are now automatically disabled.

I made the decision not to share the small helper as I didn't want to add another dependency to babel-preset-react-app and eslint-config-react-app, but that's of course open to discussion/ideas.

Resolves #9772, resolves #9782.

eddiemonge · 2020-10-12T16:51:15Z

packages/babel-preset-react-app/create.js

@@ -100,7 +105,7 @@ module.exports = function (api, opts, env) {
          // Will use the native built-in instead of trying to polyfill
          // behavior for any plugins that require one.
          ...(!hasJsxRuntime ? { useBuiltIns: true } : {}),
-          runtime: opts.runtime || 'classic',
+          runtime: hasJsxRuntime ? 'automatic' : 'classic',


is anything going to break by removing the option to pass in runtime?

No, that was introduced for v4 and hasn't been released yet. @iansu can confirm though.

Hmm. This doesn't look right. I think it is dangerous to check right in the preset. React might not necessarily be resolvable from that path (e.g. a monorepo setup). I think it was correct to keep this an option in the preset.

It also makes the preset's behavior non-deterministic depending on whether you install React before or after you first compile you code. Wrong output might get cached.

Hi @gaearon, we discussed the risk around resolution on the last call, but weren't sure of the right path forward. I've asked @ianschmitz and @iansu for their thoughts on the new issue you've raised too - thanks!

mrmckeb · 2020-10-13T08:08:27Z

packages/eslint-config-react-app/base.js

    'react/jsx-uses-vars': 'warn',
-    'react/react-in-jsx-scope': 'error',
+    ...(!hasJsxRuntime && {
+      'react/jsx-uses-react': 'warn',


According to the blog post, it won't hurt if users still import React, however they don't need to do it if the version of React they have supports the new transform.

So I think it's correct to flag React as an unused import in this scenario.

It's also worth noting that this may mislead users who have the new transform installed, but aren't using Create React App and haven't configured Babel for the new transform.

If we release the ESLint config as a major, and add that to the release notes, I think we'll be fine.

Note that opening a project to see a hundred lint warnings would be a bad experience. Especially if people don’t realize there is a codemod they can run. They will also be copy-pasting code from the web that has this import. How do we plan to explain this?

I almost think it shouldn’t warn in the transitional period. We can tighten it up later as a separate breaking change.

I had it that way - then flipped it, as I wasn't sure. We can swap that back of course.

This will be a major version, so we do have the opportunity to detail these changes (and why) in the release notes - but I understand not everyone reads those. We could also look to add a custom ESLint rule for this - but that seems like overkill.

This has been changed as a part of #9751, @gaearon.

We can change this later, and I'll reach out to the eslint-plugin-react team about this too, as it might make sense to have the rule be 'smarter' in future.

* Update packages (facebook#9081) * Fix dotenv file loading order (facebook#9037) * Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * feat: remove typescript flag and NODE_PATH support (facebook#8934) * Update question issue template * Update getting-started.md to match templates (facebook#9089) * Upgrade to Jest 26 (facebook#8955) * Update Jest to 26 * Upgrade to Jest 26.0.1 * Use jest-circus test runner by default * Try resolving test runner to fix behavior tests * Run TypeScript verification in new context * Delete globalThis if polyfilled * feat(react-scripts): allow testMatch for jest config (facebook#9114) resolves facebook#8637 * Add support for absolute paths when using url() in CSS (facebook#7937) * Support scss absolute path resolution for url() Adding resolve-url-loader broke all apps using scss with centralized assets folder and all url(./assets/*.png) broke (facebook#7023). This change allows apps to use url(/assets/*.png) and it would map to src/assets/*.png * test: Add global scss assets test * Upgrade dependencies (facebook#9132) * Fix typo in docs (facebook#9135) * Add performance relayer + documentation (web-vitals) (facebook#9116) Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update deployment docs for Azure Static Web Apps (facebook#9042) Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> * Replace Spectrum links with GitHub Discussions (facebook#9102) * Use process.execPath to spawn node subprocess (facebook#8694) * Upgrade dependencies (facebook#9196) * Bump version of Verdaccio (facebook#7787) * Support ESLint 7.x (facebook#8978) * Fix chai URL (facebook#8895) The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning. * Explain how to uninstall create-react-app globally (facebook#9244) * Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn * Upgrade dependencies (facebook#9317) * Switch to the Workbox InjectManifest plugin (facebook#9205) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Upgrade refresh plugin (facebook#9348) * feat: Update ESLint dependencies (facebook#9251) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Remove server worker registration from default templates (facebook#9349) * Clarify wording in adding TypeScript to existing project (facebook#9231) * feat: better refresh plugin integration (facebook#9375) * feat: exit on outdated create-react-app version (facebook#9359) * Prepare 4.0.0 alpha release * Updated README.md Templates to Follow ESLint Markdown Rules (facebook#9241) * [Doc] fix React Testing Library example (facebook#9245) * Update running-tests.md (facebook#9380) * Add Fast Refresh warning when using React < 16.10 (facebook#9350) * Publish refreshOverlayInterop with react-dev-utils (facebook#9390) * fix: remove deprecated rule (facebook#9401) * clean formatMessage usage (facebook#9059) * feat: Update testing-library dependencies to latest (facebook#9252) * fix: use default modules option from `preset-env` (facebook#9374) * Bump immer version (facebook#8933) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> * Upgrade whatwg-fetch (facebook#9392) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Fix template name handling (facebook#9412) * Prepare 4.0.0 alpha release * chore: update to jest@26.3 (facebook#9461) * Create SECURITY.md * Add 3.4.2 to changelog * Add 3.4.3 to the changelog * Fixes in the /packages/react-devs-utils/README.md file (facebook#9471) * Added CRA logo in README.md (facebook#9363) * Added React logo in README.md * Added React logo in README file that makes looks nicer now. * Added CRA Logo in README.md that looks nicer * Replacing React Logo with CRA Logo instead Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> * Update README.md Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> * Update Vercel deployment documentation (facebook#9560) * Fix insensitive language in Docusaurus docs (facebook#9618) * Remove ESLint extends and add Jest rules (facebook#9587) * fix: Fix azure-pipelines' endOfLine (facebook#9258) * Update template dependencies to latest version (facebook#9526) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update running-tests.md (facebook#9073) * feat: Update ESLint dependencies (facebook#9434) * Emphasise that Next.js is capable of SSG (facebook#9630) * docs: add alt tag to homepage logo (facebook#9499) * fix: resolve CI build failure (facebook#9640) * Use new JSX transform with React 17 (facebook#9645) * Upgrade dependencies (facebook#9639) * Prepare 4.0.0 alpha release * Update postcss-safe-parser * Prepare 4.0.0 alpha release * Update CODEOWNERS * fix: resolve ESLint config from appPath (facebook#9683) * Add AVIF image support (facebook#9611) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * fix: resolve new JSX runtime issues (facebook#9788) * Upgrade Docusaurus to latest version (facebook#9728) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Joe Haddad <timer150@gmail.com> Co-authored-by: Brody McKee <mrmckeb@hotmail.com> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: Josemaria Nriagu <49484425+josenriagu@users.noreply.github.com> Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> Co-authored-by: atlanteh <atlanteh@gmail.com> Co-authored-by: Jakob Krigovsky <jakob@krigovsky.com> Co-authored-by: Houssein Djirdeh <houssein.djirdeh@gmail.com> Co-authored-by: Burke Holland <burkeholland@gmail.com> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Brian Morearty <brian@morearty.org> Co-authored-by: Nick McCurdy <nick@nickmccurdy.com> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Dylan Brookes <24858006+merelinguist@users.noreply.github.com> Co-authored-by: Michael Mok <pmmmwh@gmail.com> Co-authored-by: Rafael Quijada <firehawk09@users.noreply.github.com> Co-authored-by: Sakito Mukai <sakito21@gmail.com> Co-authored-by: Andy C <7357845+andycanderson@users.noreply.github.com> Co-authored-by: Kline Moralee <klinemoralee@gmail.com> Co-authored-by: Gerrit Alex <admin@gerritalex.de> Co-authored-by: Sam Chen <chenxsan@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Stafford Williams <staff0rd@users.noreply.github.com> Co-authored-by: Lenard Pratt <striderman34@gmail.com> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Webdot_30 <nwaforuchechukwu2007@gmail.com> Co-authored-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com> Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Timothy <1695613+timothyis@users.noreply.github.com> Co-authored-by: Liam Duffy <3338808+liamness@users.noreply.github.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: Hongbo Miao <Hongbo.Miao@outlook.com> Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com>

* Update template tests (facebook#8705) * Bump TypeScript template to 3.8 (facebook#8713) * Add .cjs and .mjs files support to test runner (facebook#8768) * Use simplified import of @testing-library/jest-dom (facebook#8763) * Include absoluteRuntime in babel preset docs (facebook#5847) * Specify what files are served form a bare local copy (facebook#8749) * fix: handle templates without main package field (facebook#8734) * Add experimental react-refresh support (facebook#8582) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Add setupTests.js to the list of generated files (facebook#8791) * Simplify wording in setting-up-your-editor.md (facebook#8684) * Update url to see prettier in action (facebook#8610) * Bump acorn from 6.4.0 to 6.4.1 in /docusaurus/website (facebook#8656) Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Don't use webpack multi entry unnecessarily (facebook#8834) Passing an array with a single entry is not equivalent. This causes Webpack to generate another wrapper module around the entry. This is just unnecessary overhead and bytes. * Widen eslint-config-react-app peer dependency versions (facebook#8892) See facebook#7790 for a previous similar PR. * Revert "Replace favicon in templates (facebook#8194)" (facebook#8925) This reverts commit c03bb36. * Minor/patch dependency upgrades (facebook#8947) * Upgrade to Jest 25 (facebook#8362) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Drop Node 8 support (facebook#8948) * Bump React Hooks ESLint plugin to 4.0.0 (facebook#8939) * Update build script deployment URL (facebook#8651) * Do not check for interactive session to shut down dev server (facebook#8845) * Support source maps for scss in dev environments (facebook#8638) * Skip stdin resuming to support lerna parallel (facebook#8700) * Set resetMocks to true by default in jest config (facebook#7899) * Add import/no-anonymous-default-export lint rule (facebook#8926) * Upgrade testing-library packages (facebook#8406) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Bump style-loader to 1.2.1 (facebook#8891) * Support devDependencies in templates (facebook#8838) * fix react-refresh babel plugin not applied (facebook#8952) * Add a VSCode tip in the CSS reset section (facebook#8246) * Add back in --stats output from webpack. (facebook#8790) * Fix --use-pnp for Yarn 2 (facebook#8460) * Replace period in CSS Module classnames (facebook#8492) * Move shortlinks to cra.link (facebook#8957) * Remove outdated comment (facebook#8858) * bump webpack-dev-server to 3.11.0 (facebook#8975) Co-authored-by: Marc Hassan <marc@unqork.com> * Dependency major version upgrades (facebook#8950) * Update packages (facebook#9081) * Fix dotenv file loading order (facebook#9037) * Fix dotenv file loading order * tests: fix failing env tests * tests: fix more failing tests Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * feat: remove typescript flag and NODE_PATH support (facebook#8934) * Update question issue template * Update getting-started.md to match templates (facebook#9089) * Upgrade to Jest 26 (facebook#8955) * Update Jest to 26 * Upgrade to Jest 26.0.1 * Use jest-circus test runner by default * Try resolving test runner to fix behavior tests * Run TypeScript verification in new context * Delete globalThis if polyfilled * feat(react-scripts): allow testMatch for jest config (facebook#9114) resolves facebook#8637 * Add support for absolute paths when using url() in CSS (facebook#7937) * Support scss absolute path resolution for url() Adding resolve-url-loader broke all apps using scss with centralized assets folder and all url(./assets/*.png) broke (facebook#7023). This change allows apps to use url(/assets/*.png) and it would map to src/assets/*.png * test: Add global scss assets test * Upgrade dependencies (facebook#9132) * Fix typo in docs (facebook#9135) * Add performance relayer + documentation (web-vitals) (facebook#9116) Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update deployment docs for Azure Static Web Apps (facebook#9042) Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> * Replace Spectrum links with GitHub Discussions (facebook#9102) * Use process.execPath to spawn node subprocess (facebook#8694) * Upgrade dependencies (facebook#9196) * Bump version of Verdaccio (facebook#7787) * Support ESLint 7.x (facebook#8978) * Fix chai URL (facebook#8895) The root domain, chaijs.com, does not serve a valid certificate and gives a browser warning. * Explain how to uninstall create-react-app globally (facebook#9244) * Explain how to uninstall create-react-app globally * Add uninstallation intructions for yarn * Upgrade dependencies (facebook#9317) * Switch to the Workbox InjectManifest plugin (facebook#9205) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Upgrade refresh plugin (facebook#9348) * feat: Update ESLint dependencies (facebook#9251) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Remove server worker registration from default templates (facebook#9349) * Clarify wording in adding TypeScript to existing project (facebook#9231) * feat: better refresh plugin integration (facebook#9375) * feat: exit on outdated create-react-app version (facebook#9359) * Prepare 4.0.0 alpha release * Updated README.md Templates to Follow ESLint Markdown Rules (facebook#9241) * [Doc] fix React Testing Library example (facebook#9245) * Update running-tests.md (facebook#9380) * Add Fast Refresh warning when using React < 16.10 (facebook#9350) * Publish refreshOverlayInterop with react-dev-utils (facebook#9390) * fix: remove deprecated rule (facebook#9401) * clean formatMessage usage (facebook#9059) * feat: Update testing-library dependencies to latest (facebook#9252) * fix: use default modules option from `preset-env` (facebook#9374) * Bump immer version (facebook#8933) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> * Upgrade whatwg-fetch (facebook#9392) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Fix template name handling (facebook#9412) * Prepare 4.0.0 alpha release * chore: update to jest@26.3 (facebook#9461) * Create SECURITY.md * Add 3.4.2 to changelog * Add 3.4.3 to the changelog * Fixes in the /packages/react-devs-utils/README.md file (facebook#9471) * Added CRA logo in README.md (facebook#9363) * Added React logo in README.md * Added React logo in README file that makes looks nicer now. * Added CRA Logo in README.md that looks nicer * Replacing React Logo with CRA Logo instead Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> * Update README.md Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> * Update Vercel deployment documentation (facebook#9560) * Fix insensitive language in Docusaurus docs (facebook#9618) * Remove ESLint extends and add Jest rules (facebook#9587) * fix: Fix azure-pipelines' endOfLine (facebook#9258) * Update template dependencies to latest version (facebook#9526) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Update running-tests.md (facebook#9073) * feat: Update ESLint dependencies (facebook#9434) * Emphasise that Next.js is capable of SSG (facebook#9630) * docs: add alt tag to homepage logo (facebook#9499) * fix: resolve CI build failure (facebook#9640) * Use new JSX transform with React 17 (facebook#9645) * Upgrade dependencies (facebook#9639) * Prepare 4.0.0 alpha release * Update postcss-safe-parser * Prepare 4.0.0 alpha release * Update CODEOWNERS * fix: resolve ESLint config from appPath (facebook#9683) * Add AVIF image support (facebook#9611) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * fix: resolve new JSX runtime issues (facebook#9788) * Upgrade Docusaurus to latest version (facebook#9728) * Replace deprecated eslint-loader with eslint-webpack-plugin (facebook#9751) * Replace deprecated eslint-loader by eslint-webpack-plugin * Update eslintFormatter for eslint-webpack-plugin * fix: always enable jsx-uses-react Co-authored-by: Brody McKee <mrmckeb@hotmail.com> * Add 3.4.4 to the changelog * Bump resolve-url-loader version (facebook#9841) * Bump resolve-url-loader version * Unpin resolve-url-loader * Fix refreshOverlayInterop module scope error (facebook#9805) * Make eslint-plugin-jest an optional peerDependency (facebook#9670) * feat(eslint-config-react-app): Add jest & testing-library rules (facebook#8963) * feat: Update ESLint dependencies (facebook#9856) * feat: remove unused React imports (facebook#9853) * feat: Update all dependencies (facebook#9857) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * New JSX Transform opt out (facebook#9861) * Use new JSX setting with TypeScript 4.1.0 (facebook#9734) * Upgrade to React 17 (facebook#9863) * Prepare 4.0.0 alpha release * Pass JSX runtime setting to Babel preset in Jest config (facebook#9865) * Prepare 4.0.0 release * Update CHANGELOG * Add link to Open Collective (facebook#9864) * Update CHANGELOG * Update react dom in error overlay * Prepare 4.0.0 release * Publish - babel-plugin-named-asset-import@0.3.7 - babel-preset-react-app@10.0.0 - confusing-browser-globals@1.0.10 - cra-template-typescript@1.1.0 - cra-template@1.1.0 - create-react-app@4.0.0 - eslint-config-react-app@6.0.0 - react-app-polyfill@2.0.0 - react-dev-utils@11.0.0 - react-error-overlay@6.0.8 - react-scripts@4.0.0 * undo antd-package removel Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Braedon Gough <38016720+braedongough@users.noreply.github.com> Co-authored-by: Andrey Sitnik <andrey@sitnik.ru> Co-authored-by: Kirill Korolyov <kirill.korolyov@gmail.com> Co-authored-by: Iddan Aaronsohn <mail@aniddan.com> Co-authored-by: Clément Hallet <clement@challet.eu> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: Adam Charron <adam@charrondev.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Mostafa Nawara <nawaragfx@gmail.com> Co-authored-by: Cory House <housecor@gmail.com> Co-authored-by: Michael Schmidt-Voigt <michael@schmidt-voigt.de> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sebastian Markbåge <sebastian@calyptus.eu> Co-authored-by: Minh Nguyen <minhnguyenxx@gmail.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Kenneth Skovhus <skovhus@users.noreply.github.com> Co-authored-by: Sten Arthur Laane <laanesten@gmail.com> Co-authored-by: Jeremy Wadsack <jeremy.wadsack@gmail.com> Co-authored-by: Matt Korostoff <mkorostoff@gmail.com> Co-authored-by: Hieu Do <xlu.untitled@gmail.com> Co-authored-by: Alex Krolick <alexkrolick@users.noreply.github.com> Co-authored-by: Shakib Hossain <3992124+shakib609@users.noreply.github.com> Co-authored-by: Ernesto García <gnapse@gmail.com> Co-authored-by: Eugene Chybisov <imchybisov@gmail.com> Co-authored-by: Tan Li Hau <tanhauhau@users.noreply.github.com> Co-authored-by: Maaz Syed Adeeb <maaz.adeeb@gmail.com> Co-authored-by: Sam Saccone <samccone@gmail.com> Co-authored-by: Nick McCurdy <nick@nickmccurdy.com> Co-authored-by: Evan Kennedy <evan_kennedy@yahoo.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: Chetanya Kandhari <availchet@gmail.com> Co-authored-by: Marc Hassan <marc.j.hassan@gmail.com> Co-authored-by: Marc Hassan <marc@unqork.com> Co-authored-by: Joe Haddad <timer150@gmail.com> Co-authored-by: Brody McKee <mrmckeb@hotmail.com> Co-authored-by: Josemaria Nriagu <49484425+josenriagu@users.noreply.github.com> Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl> Co-authored-by: atlanteh <atlanteh@gmail.com> Co-authored-by: Jakob Krigovsky <jakob@krigovsky.com> Co-authored-by: Houssein Djirdeh <houssein.djirdeh@gmail.com> Co-authored-by: Burke Holland <burkeholland@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Brian Morearty <brian@morearty.org> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Dylan Brookes <24858006+merelinguist@users.noreply.github.com> Co-authored-by: Michael Mok <pmmmwh@gmail.com> Co-authored-by: Rafael Quijada <firehawk09@users.noreply.github.com> Co-authored-by: Sakito Mukai <sakito21@gmail.com> Co-authored-by: Andy C <7357845+andycanderson@users.noreply.github.com> Co-authored-by: Kline Moralee <klinemoralee@gmail.com> Co-authored-by: Gerrit Alex <admin@gerritalex.de> Co-authored-by: Sam Chen <chenxsan@gmail.com> Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com> Co-authored-by: Stafford Williams <staff0rd@users.noreply.github.com> Co-authored-by: Lenard Pratt <striderman34@gmail.com> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com> Co-authored-by: Webdot_30 <nwaforuchechukwu2007@gmail.com> Co-authored-by: Raihan Nismara <31585789+raihan71@users.noreply.github.com> Co-authored-by: Eddie Monge Jr <eddiemonge@users.noreply.github.com> Co-authored-by: Timothy <1695613+timothyis@users.noreply.github.com> Co-authored-by: Liam Duffy <3338808+liamness@users.noreply.github.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: Hongbo Miao <Hongbo.Miao@outlook.com> Co-authored-by: Alexey Pyltsyn <lex61rus@gmail.com> Co-authored-by: Clément DUNGLER <clementdungler@gmail.com> Co-authored-by: Johannes Pfeiffer <johannespfeiffer@netnexus.de> Co-authored-by: Sai <sai@pelago.com.sg>

chungbeopro

actions/runner-images#2212 (comment)

mrmckeb requested review from ianschmitz, iansu and petetnt as code owners October 12, 2020 16:34

facebook-github-bot added the CLA Signed label Oct 12, 2020

mrmckeb force-pushed the fix/move-react-transform-check branch from 371e1fc to 92ce524 Compare October 12, 2020 16:39

eddiemonge reviewed Oct 12, 2020

View reviewed changes

mrmckeb force-pushed the fix/move-react-transform-check branch 2 times, most recently from 507f348 to e922613 Compare October 13, 2020 08:06

fix: resolve new JSX runtime issues

54d71d3

mrmckeb force-pushed the fix/move-react-transform-check branch from e922613 to 54d71d3 Compare October 13, 2020 08:18

mrmckeb commented Oct 13, 2020

View reviewed changes

iansu added this to the 4.0 milestone Oct 14, 2020

ianschmitz approved these changes Oct 14, 2020

View reviewed changes

iansu approved these changes Oct 14, 2020

View reviewed changes

mrmckeb merged commit 1f2d387 into master Oct 15, 2020

mrmckeb deleted the fix/move-react-transform-check branch October 15, 2020 09:27

mrmckeb mentioned this pull request Oct 18, 2020

Handle new JSX transform jsx-eslint/eslint-plugin-react#2834

Closed

ianschmitz added the tag: bug fix label Oct 23, 2020

chungbeopro reviewed Dec 7, 2020

View reviewed changes

drich7449 mentioned this pull request Mar 8, 2021

[Snyk] Security upgrade react-dev-utils from 9.1.0 to 11.0.0 drich7449/create-react-app#24

Open

hzhz mentioned this pull request Mar 8, 2021

[Snyk] Security upgrade react-dev-utils from 10.2.1 to 11.0.0 hzhz/create-react-app#18

Open

sirinartk mentioned this pull request Mar 8, 2021

[Snyk] Security upgrade react-dev-utils from 9.1.0 to 11.0.0 sirinartk/create-react-app#19

Closed

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021

fix: resolve new JSX runtime issues (facebook#9788)

0c6034d

This was referenced Sep 15, 2021

[Snyk] Fix for 1 vulnerabilities sirinartk/create-react-app#44

Closed

[Snyk] Fix for 1 vulnerabilities hzhz/create-react-app#39

Open

[Snyk] Fix for 1 vulnerabilities drich7449/create-react-app#50

Open

hzhz mentioned this pull request Dec 26, 2022

[Snyk] Fix for 1 vulnerabilities hzhz/create-react-app#67

Open

sirinartk mentioned this pull request Dec 27, 2022

[Snyk] Fix for 1 vulnerabilities sirinartk/create-react-app#68

Closed

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023

fix: resolve new JSX runtime issues (facebook#9788)

2a5f7fa

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023

fix: resolve new JSX runtime issues (facebook#9788)

d7a7c8e

sirinartk mentioned this pull request Dec 1, 2023

[Snyk] Fix for 1 vulnerabilities sirinartk/create-react-app#86

Open

Omrisnyk mentioned this pull request Apr 15, 2024

[Snyk] Security upgrade react-scripts from 1.1.4 to 4.0.0 Omrisnyk/lock-walker#54

Open

sirinartk mentioned this pull request May 22, 2024

[Snyk] Fix for 2 vulnerabilities sirinartk/create-react-app#97

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: resolve new JSX transform issues #9788

fix: resolve new JSX transform issues #9788

mrmckeb commented Oct 12, 2020

eddiemonge Oct 12, 2020

mrmckeb Oct 13, 2020

gaearon Oct 17, 2020

gaearon Oct 17, 2020

gaearon Oct 17, 2020

mrmckeb Oct 17, 2020

mrmckeb Oct 13, 2020

mrmckeb Oct 13, 2020

gaearon Oct 15, 2020

gaearon Oct 15, 2020

mrmckeb Oct 17, 2020

mrmckeb Oct 18, 2020 •

edited

Loading

chungbeopro left a comment

fix: resolve new JSX transform issues #9788

fix: resolve new JSX transform issues #9788

Conversation

mrmckeb commented Oct 12, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrmckeb Oct 18, 2020 • edited Loading

Choose a reason for hiding this comment

chungbeopro left a comment

Choose a reason for hiding this comment

mrmckeb Oct 18, 2020 •

edited

Loading