Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Tasks fixes and Fix #9953 #9858

Closed
wants to merge 7 commits into from

Conversation

ehsankhfr
Copy link
Contributor

@ehsankhfr ehsankhfr commented Oct 22, 2020

  • Few of the tests are still failing because of breaking the lint no-conditional-expect rule. This PR provides a fix for those tests.
  • The plugin-syntax-jsx is missing for the Simple tasks, which makes the build broken while running the task script.
  • The babel preset options fix in package.json, to solve the ejected application's tests run issue (something similar to Fix [v4] Bug: React 17, React is not defined after ejecting #9953, but in this case for running tests)

@facebook-github-bot
Copy link

Hi @ehsankhfr!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@ehsankhfr ehsankhfr marked this pull request as draft October 22, 2020 16:39
@ehsankhfr ehsankhfr marked this pull request as ready for review October 22, 2020 16:50
@ehsankhfr ehsankhfr changed the title Tests fix for extractSourceMap Test fixes for extractSourceMap Oct 22, 2020
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ehsankhfr ehsankhfr changed the title Test fixes for extractSourceMap Simple Tasks fixe Oct 24, 2020
@ehsankhfr ehsankhfr changed the title Simple Tasks fixe Simple Tasks fixes Oct 24, 2020
@ehsankhfr ehsankhfr marked this pull request as draft October 24, 2020 15:05
@ehsankhfr ehsankhfr marked this pull request as ready for review October 25, 2020 19:36
@ehsankhfr ehsankhfr changed the title Simple Tasks fixes Simple Tasks fixes and Fix #9953 Oct 30, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

@stale stale bot added the stale label Dec 19, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue. Thank you for your contribution!

@stale stale bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Bug: React 17, React is not defined after ejecting
2 participants