Add TypeScript 4.x as peerDependency to react-scripts #9964

sheepsteak · 2020-10-30T14:44:18Z

CRA is supposed to officially support TypeScript 4 as of 4.0.0 but react-scripts is still set at only allowing TypeScript as ^3.2.1. As the CRA TypeScript template comes with TypeScript 4 I think this is causing an install error for users on npm 7 as it now attempts to install peerDependencies by default but the TypeScript versions conflict.

If CRA now supports TypeScript 4 I think this is the correct change to make things right.

Closes #9892
Closes #9764 (not really related to this but it can close after this)
Closes #9995

ianschmitz · 2020-10-30T15:15:38Z

.gitignore

@@ -13,3 +13,4 @@ yarn-error.log*
 /.changelog
 .npm/
 yarn.lock
+.eslintcache


Can you revert? We're going to update this save location in another PR

Of course, I was just trying to figure it out 😄

neolivz · 2020-11-23T03:07:10Z

Can we merge this ASAP?

pd8 · 2020-11-23T15:54:57Z

Is there any movement on this PR, CRA team?
Currently have to get around this by doing npm i --legacy-peer-deps, however I don't want to rely on that for too long.

rati-dzidziguri · 2021-02-02T23:18:07Z

Any update on this? We are also waiting on it and currently had to use a legacy flag, which is not a thing we want to have as a long-running thing.

sheepsteak · 2021-02-03T10:17:32Z

It's been put in the 4.0.2 milestone but there are 15 other issues to be closed in it 😩

It's frustrating because it's merged and just sat there waiting. This would be a great thing to put out in a patch release by itself as the amount of people moving to npm7 will only be increasing.

I'll started a discussion to try and persuade the team to start making smaller releases - #10489

rati-dzidziguri · 2021-02-03T11:07:48Z

Please try to escalate this as Node 15 and NPM7 with workspaces are something that people are switching to, making it almost impossible to properly use the latest LTS software and force us to do the different hack.

rati-dzidziguri · 2021-02-03T23:03:34Z

Thank you so much 4.0.2 released 4 hours ago, and I can confirm the issue is fixed there.

* Fix noFallthroughCasesInSwitch/jsx object is not extensible (facebook#9921) Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com> * Add logo license to README * Remove trailing space in reportWebVitals.ts (facebook#10040) * docs: add React Testing Library as a library requiring jsdom (facebook#10052) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Increase Workbox's maximumFileSizeToCacheInBytes (facebook#10048) * Create FUNDING.yml * replace inquirer with prompts (facebook#10083) - remove `react-dev-utils/inquirer` public import * Prepare 4.0.1 release * Prepare 4.0.1 release * Publish - cra-template-typescript@1.1.1 - cra-template@1.1.1 - create-react-app@4.0.1 - react-dev-utils@11.0.1 - react-scripts@4.0.1 * chore: bump web-vital dependency version (facebook#10143) * chore: bump typescript version (facebook#10141) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964) * remove chalk from formatWebpackMessages (facebook#10198) * Upgrade @svgr/webpack to fix build error (facebook#10213) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Improve vendor chunk names in development (facebook#9569) * Update postcss packages (facebook#10003) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Recovered some integration tests (facebook#10091) * Upgrade sass-loader (facebook#9988) * Move ESLint cache file into node_modules (facebook#9977) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> * Revert "Update postcss packages" (facebook#10216) This reverts commit 580ed5d. * Remove references to Node 8 (facebook#10214) * fix(react-scripts): add missing peer dependency react and update react-refresh-webpack-plugin (facebook#9872) * Update using-the-public-folder.md (facebook#10314) Some library --> Some libraries * docs: add missing override options for Jest config (facebook#9473) * Fix CI tests (facebook#10217) * appTsConfig immutability handling by immer (facebook#10027) Co-authored-by: mad-jose <joset@yeswearemad.com> * Add support for new BUILD_PATH advanced configuration variable (facebook#8986) * Add opt-out for eslint-webpack-plugin (facebook#10170) * Prepare 4.0.2 release * Publish - cra-template-typescript@1.1.2 - cra-template@1.1.2 - create-react-app@4.0.2 - react-dev-utils@11.0.2 - react-error-overlay@6.0.9 - react-scripts@4.0.2 * tests: update test case to match the description (facebook#10384) * Bump webpack-dev-server 3.11.0 -> 3.11.1 (facebook#10312) Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs * Upgrade eslint-webpack-plugin to fix opt-out flag (facebook#10590) * update immer to 8.0.1 to address vulnerability (facebook#10412) Resolves facebook#10411 Bumps immer version to 8.0.1 to address the prototype pollution vulnerability with the current 7.0.9 version. * Prepare 4.0.3 release * Update CHANGELOG * Publish - create-react-app@4.0.3 - react-dev-utils@11.0.3 - react-scripts@4.0.3 Co-authored-by: Ryota Murakami <dojce1048@gmail.com> Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com> Co-authored-by: Ian Sutherland <ian@iansutherland.ca> Co-authored-by: sho90 <aznecosann@gmail.com> Co-authored-by: Anyul Rivas <anyulled@gmail.com> Co-authored-by: Ian Schmitz <ianschmitz@gmail.com> Co-authored-by: Jeffrey Posnick <jeffy@google.com> Co-authored-by: Evan Bacon <baconbrix@gmail.com> Co-authored-by: Sahil Purav <sahil5684@gmail.com> Co-authored-by: Hakjoon Sim <trainto@gmail.com> Co-authored-by: Chris Shepherd <chris@chrisshepherd.me> Co-authored-by: Jason Williams <936006+jasonwilliams@users.noreply.github.com> Co-authored-by: Jabran Rafique⚡️ <jabranr@users.noreply.github.com> Co-authored-by: John Ruble <johnruble@gmail.com> Co-authored-by: Morten N.O. Nørgaard Henriksen <morten.n.o.henriksen@icloud.com> Co-authored-by: Sergey Makarov <serega.s.makar@gmail.com> Co-authored-by: EhsanKhaki <ehsankhfr@gmail.com> Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com> Co-authored-by: Aviv Hadar <Avivhdr@gmail.com> Co-authored-by: Tobias Büschel <13087421+tobiasbueschel@users.noreply.github.com> Co-authored-by: mad-jose <44253495+josezone@users.noreply.github.com> Co-authored-by: mad-jose <joset@yeswearemad.com> Co-authored-by: Andrew Hyndman <ajhyndman@hotmail.com> Co-authored-by: Brody McKee <mrmckeb@users.noreply.github.com> Co-authored-by: James George <jamesgeorge998001@gmail.com> Co-authored-by: Dion Woolley <woolley.dion@gmail.com> Co-authored-by: Walker Clem <51654951+wclem4@users.noreply.github.com>

davetapley · 2022-07-21T19:32:19Z

@sheepsteak I presume your assumption was that ^3.2.1 should still be fully supported in CRA 4 (hence the ||)?

I ask because a couple of us are seeing ⬇️ unless we go from ^3.2.1 to ^4, but it's easy to miss during CRA 3 to 4 upgrade because npm doesn't warn about bad peer deps 🤔

Dev Server does not always show typescript compilation errors #10852

ljharb · 2022-07-21T20:09:33Z

@davetapley npm 7+ definitely warns about bad peer deps, fwiw.

davetapley · 2022-07-21T20:13:44Z

@ljharb sorry, bad phrasing on my part: npm doesn't warn about bad peer deps because ^3.2.1 is still in the spec ⬇️
(even though #10852 (comment) suggests that it isn't fully supported)

create-react-app/packages/react-scripts/package.json

Lines 96 to 98 in 228528c

    
           "peerDependencies": { 
        
             "typescript": "^3.2.1 || ^4" 
        
           },

sheepsteak requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners October 30, 2020 14:44

facebook-github-bot added the CLA Signed label Oct 30, 2020

ianschmitz added the tag: bug fix label Oct 30, 2020

ianschmitz added this to the 4.0.1 milestone Oct 30, 2020

ianschmitz reviewed Oct 30, 2020

View reviewed changes

sheepsteak force-pushed the typescript-4-peer branch 2 times, most recently from 7d74490 to 3008a5b Compare October 30, 2020 15:48

n3tr mentioned this pull request Nov 3, 2020

create-react-app --template typescript creates unresolvable dependency conflict #9995

Closed

ljharb mentioned this pull request Nov 5, 2020

[BUG] Unable to resolve dependency in Create React App Typescript template npm/cli#2128

Closed

Add TypeScript 4 as a valid peerDependency version

228528c

sheepsteak force-pushed the typescript-4-peer branch from 3008a5b to 228528c Compare November 13, 2020 17:29

sheepsteak requested a review from ianschmitz November 13, 2020 18:39

iansu modified the milestones: 4.0.1, 4.0.2 Nov 23, 2020

dwelle mentioned this pull request Nov 23, 2020

Bump typescript from 4.0.5 to 4.1.2 excalidraw/excalidraw#2404

Closed

ianschmitz changed the title ~~Add TypeScript 4 as a valid peerDependency version of react-scripts~~ Add TypeScript 4.x as peerDependency to react-scripts Nov 26, 2020

ianschmitz merged commit 9b08e3c into facebook:master Nov 26, 2020

sheepsteak deleted the typescript-4-peer branch November 26, 2020 08:37

Semigradsky mentioned this pull request Dec 6, 2020

TypeScript 4 support #9515

Closed

This was referenced Dec 17, 2020

[Snyk] Security upgrade jest from 24.9.0 to 26.0.0 drich7449/create-react-app#18

Open

[Snyk] Security upgrade jest from 25.5.4 to 26.0.0 hzhz/create-react-app#11

Open

This was referenced Dec 17, 2020

[Snyk] Security upgrade jest from 24.0.0 to 26.0.0 math4youbyusgroupillinois/create-react-app#23

Open

[Snyk] Security upgrade jest from 24.9.0 to 26.0.0 sirinartk/create-react-app#13

Closed

snyk-bot mentioned this pull request Mar 30, 2021

[Snyk] Fix for 1 vulnerabilities hzhz/create-react-app#21

Open

snyk-bot mentioned this pull request Apr 7, 2021

[Snyk] Security upgrade jest from 25.5.4 to 26.0.0 hzhz/create-react-app#22

Open

chludwig-haufe mentioned this pull request Apr 8, 2021

TypeScript dependency conflict with npm 7 / node 14 EliEladElrom/cra-template-must-have-libraries#2

Closed

wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021

Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

00b9ff4

This was referenced Sep 15, 2021

[Snyk] Fix for 1 vulnerabilities sirinartk/create-react-app#44

Closed

[Snyk] Fix for 1 vulnerabilities hzhz/create-react-app#39

Open

[Snyk] Fix for 1 vulnerabilities drich7449/create-react-app#50

Open

This was referenced Apr 12, 2022

[Snyk] Fix for 26 vulnerabilities sirinartk/create-react-app#54

Closed

[Snyk] Fix for 25 vulnerabilities drich7449/create-react-app#56

Open

davetapley mentioned this pull request Jul 21, 2022

Dev Server does not always show typescript compilation errors #10852

Open

phoenixy1 mentioned this pull request Nov 3, 2022

Fix npm installation failure issue (issue #388) plaid/quickstart#389

Merged

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 19, 2023

Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

12dfd73

abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023

Add TypeScript 4.x as peerDependency to react-scripts(facebook#9964)

540d510

hzhz mentioned this pull request Jun 23, 2023

[Snyk] Fix for 1 vulnerabilities hzhz/create-react-app#77

Open

sirinartk mentioned this pull request Jun 30, 2023

[Snyk] Security upgrade jest from 24.9.0 to 26.0.0 sirinartk/create-react-app#77

Open

lili2311 mentioned this pull request Jun 30, 2023

[Snyk-dev] Security upgrade jest from 24.9.0 to 26.0.0 lili2311/create-react-app#11

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add TypeScript 4.x as peerDependency to react-scripts #9964

Add TypeScript 4.x as peerDependency to react-scripts #9964

sheepsteak commented Oct 30, 2020 •

edited

Loading

ianschmitz Oct 30, 2020

sheepsteak Oct 30, 2020

neolivz commented Nov 23, 2020

pd8 commented Nov 23, 2020

rati-dzidziguri commented Feb 2, 2021

sheepsteak commented Feb 3, 2021

rati-dzidziguri commented Feb 3, 2021

rati-dzidziguri commented Feb 3, 2021 •

edited

Loading

davetapley commented Jul 21, 2022

ljharb commented Jul 21, 2022

davetapley commented Jul 21, 2022

Add TypeScript 4.x as peerDependency to react-scripts #9964

Add TypeScript 4.x as peerDependency to react-scripts #9964

Conversation

sheepsteak commented Oct 30, 2020 • edited Loading

ianschmitz Oct 30, 2020

Choose a reason for hiding this comment

sheepsteak Oct 30, 2020

Choose a reason for hiding this comment

neolivz commented Nov 23, 2020

pd8 commented Nov 23, 2020

rati-dzidziguri commented Feb 2, 2021

sheepsteak commented Feb 3, 2021

rati-dzidziguri commented Feb 3, 2021

rati-dzidziguri commented Feb 3, 2021 • edited Loading

davetapley commented Jul 21, 2022

ljharb commented Jul 21, 2022

davetapley commented Jul 21, 2022

sheepsteak commented Oct 30, 2020 •

edited

Loading

rati-dzidziguri commented Feb 3, 2021 •

edited

Loading