Revert to default to {} in useLogo approach

facebook · Oct 19, 2020 · bf593e0 · bf593e0
1 parent 89a5131
commit bf593e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/docusaurus-theme-classic/src/theme/hooks/useLogo.ts b/packages/docusaurus-theme-classic/src/theme/hooks/useLogo.ts
@@ -13,7 +13,7 @@ import useThemeConfig from '../../utils/useThemeConfig';
 
 const useLogo = (): useLogoReturns => {
   const {
-    navbar: {logo},
+    navbar: {logo = {}},
   } = useThemeConfig();
   const {isDarkTheme} = useThemeContext();
   const logoLink = useBaseUrl(logo.href || '/');

diff --git a/packages/docusaurus-theme-classic/src/validateThemeConfig.js b/packages/docusaurus-theme-classic/src/validateThemeConfig.js
@@ -39,7 +39,6 @@ const DEFAULT_CONFIG = {
   navbar: {
     hideOnScroll: false,
     items: [],
-    logo: {},
   },
 };
 exports.DEFAULT_CONFIG = DEFAULT_CONFIG;
@@ -249,7 +248,7 @@ const ThemeConfigSchema = Joi.object({
       srcDark: Joi.string(),
       href: Joi.string(),
       target: Joi.string(),
-    }).default({}),
+    }),
   }).default(DEFAULT_CONFIG.navbar),
   footer: Joi.object({
     style: Joi.string().equal('dark', 'light').default('light'),