Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Add themeConfig.noIndex option #3528

Closed
slorber opened this issue Oct 2, 2020 · 2 comments · Fixed by #3573
Closed

v2: Add themeConfig.noIndex option #3528

slorber opened this issue Oct 2, 2020 · 2 comments · Fixed by #3573
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. hacktoberfest help wanted Asking for outside help and/or contributions to this particular issue or PR.

Comments

@slorber
Copy link
Collaborator

slorber commented Oct 2, 2020 •
edited
Loading

Feature

v1 had a noIndex option: https://docusaurus.io/docs/en/site-config#noindex-boolean

Let's add it to v2 too!

Also need to:

There are scripts to easily test the migration cli, look at scripts yarn test:v1Migration:migrate && yarn test:v1Migration:start
@slorber slorber added bug An error in the Docusaurus core causing instability or issues with its execution hacktoberfest good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. help wanted Asking for outside help and/or contributions to this particular issue or PR. feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. and removed bug An error in the Docusaurus core causing instability or issues with its execution labels Oct 2, 2020
@imskr
Copy link
Contributor

imskr commented Oct 2, 2020

I can fix this! @slorber

@slorber
Copy link
Collaborator Author

slorber commented Oct 5, 2020

Yes @imskr thanks

hamzahamidi added a commit to hamzahamidi/Docusaurus that referenced this issue Oct 11, 2020
@hamzahamidi
feat(v2): Add themeConfig.noIndex option facebook#3528
cb6fe8b
@hamzahamidi hamzahamidi mentioned this issue Oct 11, 2020
Merged
@slorber slorber linked a pull request Oct 12, 2020 that will close this issue
feat(v2): Add themeConfig.noIndex option #3528 #3573
Merged
hamzahamidi added a commit to hamzahamidi/Docusaurus that referenced this issue Oct 12, 2020
@hamzahamidi
feat(v2): Add themeConfig.noIndex option facebook#3528
42034fa
slorber pushed a commit that referenced this issue Oct 14, 2020
@hamzahamidi
feat(v2): Add themeConfig.noIndex option #3528 (#3573)
e0c644e 
* feat(v2): Add themeConfig.noIndex option #3528

* feat(v2): Add themeConfig.noIndex optionthrough ssrTemplate

* feat(v2): Include themeConfig.noIndex in CLI migration v1 to v2

* feat(v2): Remove themeConfig.noIndex from env dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This is not a bug or issue with Docusausus, per se. It is a feature request for the future. good first issue If you are just getting started with Docusaurus, this issue should be a good place to begin. hacktoberfest help wanted Asking for outside help and/or contributions to this particular issue or PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(v2): Add themeConfig.noIndex option #3528 hamzahamidi/Docusaurus
2 participants
@slorber @imskr