-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict frontmatter validation #4591
Comments
I'd be willing to help with this. |
@slorber I'd like to help! |
As we have 2 volunteers, I suggest:
Can you please review each-others and make sure both PRs have some kind of consistency and similar test structure? Yes @ChayceJRoss those are the exhaustive list of frontmatter options to support |
I'd like to help too, where I can grab? |
@jakehsiao we can't split more the work than it is already. |
@slorber maybe @jakehsiao could grab the work assigned to me? I haven't been able to make much progress since I'm a beginner at ts/js |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
After testing again, the title in the MD file cannot be empty. If it is empty, an error will appear. In addition, when the title field in the MD file is Chinese, there is no problem |
I don't think it's a bug, but it's suggested to give which document's title is empty. Thank you |
Ah I see, so you had something like |
yes ,like title: , when i write md doc file in Chinese, i think the font size of the title is too large on md doc page , but I can't change it, so i make title empty 。the font size of the title, H1, H2, H3, etc. can be modified by the user? |
I see two our assignees can't arrange enough time to work. Can I take some job here? 😁 |
Yeah, I'm looking forward to your help,
…------------------ 原始邮件 ------------------
发件人: "facebook/docusaurus" ***@***.***>;
发送时间: 2021年5月6日(星期四) 晚上8:15
***@***.***>;
***@***.******@***.***>;
主题: Re: [facebook/docusaurus] Strict frontmatter validation (#4591)
I see two our assignees can't arrange enough time to work. Can I take some job here? 😁
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
please go ahead @nam-hle , as others didn't make any progress |
🚀 Feature
We should validate docs/blog/pages frontmatter against a Joi schema:
Some initial work has been done in #4590 for Docs and Blog, but is not exhaustive as it was not really the point of this PR.
Asking for help from the community to get this work completed in a more exhaustive and polished way.
Please claim this issue if you are willing to help.
The text was updated successfully, but these errors were encountered: