Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix interverted condition in formatLighthouseReport.js #10528

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: fix interverted condition in formatLighthouseReport.js #10528

merged 1 commit into from
Sep 27, 2024

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 27, 2024

Fix little typo in #10527

The condition is interverted 😅

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Sep 27, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 27, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 27, 2024

✅ [V2]

Name Link
🔨 Latest commit 7ad2d7b
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/66f69873903ce20008484d1b
😎 Deploy Preview https://deploy-preview-10528--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO Report
/ 🟠 63 🟢 98 🟢 96 🟢 100 Report
/docs/installation 🟠 51 🟢 97 🟢 100 🟢 100 Report
/docs/category/getting-started 🟠 73 🟢 100 🟢 100 🟠 86 Report
/blog 🟠 60 🟢 96 🟢 100 🟠 86 Report
/blog/preparing-your-site-for-docusaurus-v3 🔴 47 🟢 92 🟢 100 🟢 100 Report
/blog/tags/release 🟠 62 🟢 96 🟢 100 🟠 86 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟠 86 Report

@slorber slorber merged commit 3b7c828 into main Sep 27, 2024
14 of 15 checks passed
@slorber slorber deleted the slorber-patch-1 branch September 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slorber @facebook-github-bot