fix: docs asset links should follow specified docsUrl #1204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1177 and #1203. Generated asset links were not following the
docsUrl
attribute specified insiteConfig.js
. Docs assets were also placed into thedocs
folder in the build directory instead of following the specifieddocsUrl
. This PR should fix these issues.Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
Development Environment
Set
docsUrl
insiteConfig.js
tohello
and start local server. Asset links in docs should point to/hello/assets/ASSET_NAME
. Docs assets should be served from/hello/assets/ASSET_NAME
. Images should be displayed on the test site.Production Environment
Set
docsUrl
insiteConfig.js
tohello
and build the site. Asset links in docs should point to/hello/assets/ASSET_NAME
. Docs assets should be served from/hello/assets/ASSET_NAME
. Images should be displayed on the test site. (See https://marvinchin.github.io/docusaurus-demo/hello/doc1)