Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make referenced links work with code block tabs #1249

Merged
merged 2 commits into from
Feb 26, 2019
Merged

fix: make referenced links work with code block tabs #1249

merged 2 commits into from
Feb 26, 2019

Commits on Feb 26, 2019

  1. Fix bug Code block tabs broke the referenced links 

    - The reason is that the previous Codeblock implementation separates
the tabs, the markdown before tabs, and the markdown after tabs into
separate Remarkable component, thus they don't share information
regarding the reference link
- To solve this, change the Doc implementation so that one Doc
have only one Remarkable component by transforming the codeblock
into html string and add it as part of the markdown, letting the
Remarkable take care of the html string
- However, this approach made us need to ensure that there is no
newline in the codetab, otherwise, the formatting inside the
code will be broken. Thus, I replace every newline inside the
code tag with a br tag

Fix facebook#1215
    @fiennyangeln
    fiennyangeln committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    9f4a528 View commit details
    Browse the repository at this point in the history

  2. Fix prettier

    @fiennyangeln
    fiennyangeln committed Feb 26, 2019
    Configuration menu
    Copy the full SHA
    afdfb89 View commit details
    Browse the repository at this point in the history