fix: bug fix for Show HTML tag on TOC, not escaping them
#1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimdongwoo
changed the title
Show HTML tag on TOC, not escaping them #1703Show HTML tag on TOC, not escaping them
|
Deploy preview for docusaurus-2 ready! Built with commit ca0c81d |
|
Deploy preview for docusaurus-preview ready! Built with commit ca0c81d |
|
After another thought, I'm afraid that many people thought this is intended behavior and actually v2 had this problem as well.
yep Because we are showing html tag on right toc I personally think #1703 is very rare and the fix itself could break someone's site 😮 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Long time no see.
I found very easy bug on issue.
But, this PR cause broken old style. And I don't know all side effect.
We need a explicitly way to show the HTML sentence or add the HTML tag in the TOC.
If you suggest a good way, I will update this PR.
It's simple training for me.
I want more contribution for V2 from now.
Because I love TypeScript & Docusarus.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
It's simple change.
Related PRs
Nope.