Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show doc names instead of "previous" and "next" #177

Merged
merged 5 commits into from
Oct 25, 2017
Merged

Show doc names instead of "previous" and "next" #177

merged 5 commits into from
Oct 25, 2017

Conversation

JoelMarcey
Copy link
Contributor

Use the previous and next doc metadata to show docs in the buttons

screencapture-localhost-3000-docs-en-site-preparation-html-1508887201197

@JoelMarcey
Show doc names instead of previous and next
7c1b48b 
Use the previous and next doc metadata to show docs in the buttons
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 24, 2017
ericnakagawa
ericnakagawa suggested changes Oct 24, 2017
View reviewed changes
Copy link
Contributor

@ericnakagawa ericnakagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the fallback should be to use the translated copy for "Previous" and "Next". Currently it falls back to the id of the previous/next document.

ericnakagawa
ericnakagawa approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@ericnakagawa ericnakagawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for making the adjustment!

@ericnakagawa ericnakagawa merged commit 4d23bf7 into facebook:master Oct 25, 2017
@hramos hramos deleted the show-next-doc branch October 25, 2017 13:55
@hramos hramos mentioned this pull request Oct 25, 2017
Closed
@snyk-bot snyk-bot mentioned this pull request Jan 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnakagawa ericnakagawa ericnakagawa approved these changes

@hramos hramos Awaiting requested review from hramos

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelMarcey @ericnakagawa @facebook-github-bot