feat(v2): add editUrl option to docs plugin #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-preview ready! Built with commit 5f3541a |
|
Deploy preview for docusaurus-2 ready! Built with commit 5f3541a |
|
Deploy preview for docusaurus-2 ready! Built with commit 89ee3c1 |
|
Deploy preview for docusaurus-preview ready! Built with commit 89ee3c1 |
yangshun
force-pushed
the
endiliey/editUrl
branch
from
6fe6a77 to
340d232
Compare
yangshun
approved these changes
Oct 9, 2019
| @@ -23,3 +23,30 @@ | |||
| display: none; | |||
| } | |||
| } | |||
|
|
|||
| .editButton { | |||
There was a problem hiding this comment.
I've removed all of these because we should be using Infima classes instead. Anyway I decided to make it look like a link instead of a button and shifted the position to be at the bottom since it's the more common practice for docs sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
editUrloption (URL for editing) to docs plugin. If this field is set, there will be "Edit" button for each document pageHave you read the Contributing Guidelines on pull requests?
yes
Test Plan