Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove invalid attributes of nav links #1974

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 12, 2019

Motivation

Currently, because that all props are passed to NavLink, navigation links have two invalid attributes - label and position.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before:

<a class="navbar__item navbar__link" label="Docs" position="left" href="/docs/introduction">Docs</a>

After:

<a class="navbar__item navbar__link" href="/docs/introduction">Docs</a>

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2019
@lex111 lex111 changed the title fix(v2): remove nav links invalid attributes fix(v2): remove invalid attributes of nav links Nov 12, 2019
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Nov 12, 2019
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 12, 2019

Deploy preview for docusaurus-2 ready!

Built with commit a4bb6cd

https://deploy-preview-1974--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 12, 2019

Deploy preview for docusaurus-preview ready!

Built with commit a4bb6cd

https://deploy-preview-1974--docusaurus-preview.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you
🚀 Ship it ....

shipit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants