Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): add aria-label to read more links for a11y #1977

Merged
merged 1 commit into from
Nov 13, 2019

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Nov 12, 2019

Motivation

Screen readers need a more descriptive link name.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 12, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 7d9bc8f

https://deploy-preview-1977--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 7d9bc8f

https://deploy-preview-1977--docusaurus-preview.netlify.com

@endiliey endiliey changed the title fix(v2): make more explicit read more links fix(v2): add aria-label to read more links for a11y Nov 13, 2019
@endiliey endiliey added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 13, 2019
@endiliey endiliey changed the title fix(v2): add aria-label to read more links for a11y feat(v2): add aria-label to read more links for a11y Nov 13, 2019
@endiliey endiliey merged commit 64d2ec2 into facebook:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants