Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): update dependencies #1985

Merged
merged 2 commits into from
Nov 13, 2019
Merged

chore(v2): update dependencies #1985

merged 2 commits into from
Nov 13, 2019

Conversation

endiliey
Copy link
Contributor

Motivation

Stay updated :)

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

  • Manually check all updated releases page & changelog and follow migration guide
  • Yarn still works
  • Dev working
  • All ci passes

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2019
@endiliey endiliey added pr: maintenance This PR does not produce any behavior differences to end users when upgrading. and removed CLA Signed Signed Facebook CLA labels Nov 13, 2019
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 13, 2019
@@ -5,7 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

import chalk from 'chalk';
import chalk = require('chalk');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 13, 2019

Deploy preview for docusaurus-2 ready!

Built with commit a5fa70c

https://deploy-preview-1985--docusaurus-2.netlify.com

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Nov 13, 2019

Deploy preview for docusaurus-preview ready!

Built with commit a5fa70c

https://deploy-preview-1985--docusaurus-preview.netlify.com

@@ -10,8 +10,8 @@
"dependencies": {
"@endiliey/lqip-loader": "^3.0.0",
"@endiliey/responsive-loader": "^1.3.1",
"react-ideal-image": "^0.0.5",
"react-waypoint": "8.1.0",
"@endiliey/react-ideal-image": "^0.0.8",
Copy link
Contributor Author

@endiliey endiliey Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forked because that repo is so outdated.... :( (it still uses babel 7). Maintainer don't want to respond to issues and PR as well. My update is minimal stereobooster/react-ideal-image@master...endiliey:master

Interestingly with this fork main bundle size reduced by 14kbs. Crazy ... Most likely because react waypoint is bundled better now in v9
after 221kb

207kb after  wew

@endiliey endiliey merged commit cf4037e into master Nov 13, 2019
@endiliey endiliey deleted the endi/deps branch November 13, 2019 16:04
@endiliey endiliey restored the endi/deps branch November 13, 2019 16:04
@endiliey endiliey deleted the endi/deps branch November 13, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants