Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): style right sidebar scrollbar when overflow #2017

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Conversation

endiliey
Copy link
Contributor

Motivation

CSS Tweaks to be consistent like v1. see Test Plan. Feel free to close if its not a good idea

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Before
before-light
before-dark

After
after-dark
after-light

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 20, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 09d8656

https://deploy-preview-2017--docusaurus-2.netlify.com

@endiliey endiliey added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Nov 20, 2019
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 09d8656

https://deploy-preview-2017--docusaurus-preview.netlify.com

@@ -30,6 +30,24 @@
top: calc(var(--ifm-navbar-height) + 2rem);
}

.tableOfContents::-webkit-scrollbar {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not supported by FireFox, maybe we can use scrollbar color

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its not supported by firefox but its supported in all other major browsers like Safari and Chrome.

Scrollbar color is an experimental feature in Firefox >= 64 and all major browsers doesnt support that.

In fact, its a bug of mozilla. No scrollbar equivalent in mozilla https://stackoverflow.com/questions/6165472/custom-css-scrollbar-for-firefox

https://bugzilla.mozilla.org/show_bug.cgi?id=77790

Anyway, This is same behavior like v1, which is kinda battle tested. I think its ok if firefox wont see this

@yangshun yangshun merged commit 91902ed into master Nov 21, 2019
@endiliey endiliey deleted the endi/toc-css branch November 21, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants