docs(v2): Reorganize migration guide #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 05e3cd7 |
|
Deploy preview for docusaurus-preview ready! Built with commit 05e3cd7 |
|
Thank you :) let me know when its no longer WIP |
|
@endiliey I'm not very familiar with remark-toc, do you mind adding the guide here? |
endiliey
added
the
pr: documentation
|
I think just writing it has been deprecated, you might want to use remark-toc instead and pass it to docs plugin |
|
what really, dont we want to include how to pass that... |
|
Actually using remark-toc isnt really a direct workaround. Its a different syntax. Just point that it has been deprecated, and link to that github issue instead for reasoning. |
endiliey
reviewed
Nov 25, 2019
endiliey
changed the title
endiliey
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
<AUTOGENERATED_TABLE_OF_CONTENTS>Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA
Related PRs
NA