perf(v2): load algolia JS only when user interacts with search #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endiliey
added
the
pr: performance
endiliey
changed the title
|
Deploy preview for docusaurus-2 ready! Built with commit 998fc89 |
|
Deploy preview for docusaurus-preview ready! Built with commit 998fc89 |
yangshun
approved these changes
Dec 2, 2019
packages/docusaurus-theme-search-algolia/src/theme/SearchBar/index.js
Outdated
Show resolved
Hide resolved
| }); | ||
| const loadAlgoliaJS = () => { | ||
| if (!loadedJs) { | ||
| loadJS().then(a => { |
There was a problem hiding this comment.
Wanna add some error handling?
There was a problem hiding this comment.
I dont know what kind of error should be introduced. Previously doesnt have it too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Docsearch bundle size is a whooping 35kbs gzipped. That's huge ...
Trying to improve our TTI performance by only loading algolia when user interact with the search
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Still working ✌️
Notice how the bundle is only loaded when user interact with it
Benefit.
This increase our lighthouse TTI by 1s
After is 2.8s+
Before was 3.9s +
Slight caveat: