Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): hide read more button on non-truncated posts #2240

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jan 23, 2020

Motivation

Fix the bug reported on Canny - https://docusaurus.canny.io/admin/board/feature-requests/p/allow-no-truncate-on-blog-post

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Check that the blog post without the <!--truncate--> marker does not display the Read more button on the blog lists page.

@lex111 lex111 requested a review from yangshun January 23, 2020 21:25
@lex111 lex111 requested a review from wgao19 as a code owner January 23, 2020 21:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 23, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jan 23, 2020

Deploy preview for docusaurus-2 ready!

Built with commit cf254b0

https://deploy-preview-2240--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess users can still click on the title of the blog post if they want to see blog post in its own page (which can be useful if people add comments widgets there.

@yangshun yangshun merged commit 5121ac0 into facebook:master Jan 24, 2020
@lex111 lex111 deleted the hide-read-more-btn branch January 24, 2020 08:29
@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Jan 31, 2020
@lex111 lex111 restored the hide-read-more-btn branch April 18, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants