Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add instructions on Travis CI deployment #2289

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

mohamedsgap
Copy link
Contributor

I created this PR to update Docusaurus V2 Doc/deployment with Automating Deployments steps with Travis CI.
Ref Issue: #2286

Motivation

Because When I tried to use Travis CI with Docusaurus V2, I didn't find any steps for automating deployments using CI with Travis CI or even Circle CI, so I jumped back to Docusaurus V1 and I made a some update to Travis CI script to be suitable with Docusaurus V2.

@facebook-github-bot
Copy link
Contributor

Hi @mohamedsgap!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 16, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 509127c

https://deploy-preview-2289--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for adding this! Please make the suggested changes!

@@ -146,3 +146,35 @@ Render offers [free static site hosting](https://render.com/docs/static-sites) w
| **Publish Directory** | `build` |

That's it! Your app will be live on your Render URL as soon as the build finishes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this change. We should just update the newest docs.

# .travis.yml
language: node_js
node_js:
- '8'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We support Node 10 and above.

@yangshun yangshun changed the title [Doc] Add Automating Deployments with Travis CI docs(v2): add instructions on Travis CI deployment Feb 18, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 18, 2020
@mohamedsgap
Copy link
Contributor Author

Hey @yangshun I've just made the suggested changes :)

@@ -146,3 +146,35 @@ Render offers [free static site hosting](https://render.com/docs/static-sites) w
| **Publish Directory** | `build` |

That's it! Your app will be live on your Render URL as soon as the build finishes.

## Automating Deployments Using Continuous Integration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohamedsgap please remove change in this file. Docs for version 43 has already been released, so we cannot and should not add anything new to this version.

@mohamedsgap
Copy link
Contributor Author

Hi @lex111, just removed the update from v2.0.0-alpha.43

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@yangshun yangshun merged commit e656285 into facebook:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants