Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): clean up and improve Algolia styles #2376

Merged
merged 1 commit into from
Mar 8, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 7, 2020

Motivation

  • Remove unnecessary styles for searchbox element (we do not have such an search input)
  • Various improvements (baseline alignment of the selected text fragment, adding borders, removing redundant styles) - just compare screenshots below.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 7, 2020
@lex111 lex111 added this to the v2.0.0-alpha.44 milestone Mar 7, 2020
@lex111 lex111 requested a review from yangshun March 7, 2020 18:41
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 7, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 04dd1c2

https://deploy-preview-2376--docusaurus-2.netlify.com

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I never realized it wasn't unused. I verified in #1074 which added this that it's not used :/

background-size: 100%;
overflow: hidden;
text-indent: -9000px;
width: 110px;
height: 100%;
display: block;
margin-left: auto;
margin-right: 5px;
margin: 0 5px 0 auto;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sets the vertical margin to 0, which is a bit different. It'll be different in case there's another selector which changes the vertical margin. But should be fine.

@yangshun yangshun merged commit 70ba0a4 into master Mar 8, 2020
@yangshun yangshun deleted the lex111/improve-algolia-styling branch March 8, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants