-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): clarify instructions on docs-only mode #2395
Conversation
Deploy preview for docusaurus-2 ready! Built with commit 8ecb1a4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the changes? Please test it first since the previous way was incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes.
@yangshun Yes, I tested it. I am using those settings for my own site and haven’t run into any problems. But if the way you described it is the ”true way“ I‘ll adopt those new changes and integrate them into my site. Thank you. |
I don't think using |
Ah, that makes sense. Must have overlooked it, thanks for clarifying. |
Motivation
The docs-only mode instructions didn't work, this change clarifies the instructions and adds an additional step for the index page.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
N/A
Related PRs
#2378