Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): include appId key for Algolia #2413

Merged
merged 4 commits into from
Mar 17, 2020
Merged

docs(v2): include appId key for Algolia #2413

merged 4 commits into from
Mar 17, 2020

Conversation

TheodoreChu
Copy link
Contributor

appId is needed for self-hosted Docsearch

Motivation

Update Algolia information. The information is similar for v1: https://docusaurus.io/docs/en/site-config.html#algolia-object

Have you read the Contributing Guidelines on pull requests?

Not yet

Test Plan

I used it on my personal site

Related PRs

None

appId is needed for self-hosted Docsearch
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 15, 2020
@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Mar 15, 2020

Deploy preview for docusaurus-2 ready!

Built with commit a42c1cb

https://deploy-preview-2413--docusaurus-2.netlify.com

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but could you please reflect this change in other versions of docs?

@TheodoreChu TheodoreChu changed the title Update Algolia information Update Algolia information for alpha.43 Mar 16, 2020
@TheodoreChu TheodoreChu changed the title Update Algolia information for alpha.43 Update Algolia information Mar 16, 2020
@TheodoreChu
Copy link
Contributor Author

OK, I updated the information for alpha.40, alpha.43, and alpha.48

@lex111 lex111 requested a review from wgao19 as a code owner March 17, 2020 09:24
@lex111 lex111 changed the title Update Algolia information docs(v2): include appId key for Algolia Mar 17, 2020
@lex111 lex111 merged commit 99943a6 into facebook:master Mar 17, 2020
@lex111
Copy link
Contributor

lex111 commented Mar 17, 2020

@TheodoreChu thanks!

@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants