Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): update HTML markup of pagination for better a11y #2495

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 1, 2020

Motivation

Refers to #2403

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

No UI changes (this has already been changed in the new version of Infima).

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Apr 1, 2020
@lex111 lex111 added this to the v2.0.0-alpha.50 milestone Apr 1, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 62fe9ee

https://deploy-preview-2495--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 1, 2020
@lex111 lex111 changed the title refactor(v2): update HTML markup of pagination for better 11y refactor(v2): update HTML markup of pagination for better a11y Apr 1, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we should have bumped Infima version earlier, not just before a new release. The blog post avatar also needs to be updated

@yangshun yangshun merged commit d1326cd into master Apr 2, 2020
@yangshun yangshun deleted the lex111/update-paginator branch April 2, 2020 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants