Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): mention that plugin-ideal-image only perform compression on a production build #2572

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Conversation

Noah-Silvera
Copy link
Contributor

In reference to #2571

Motivation

I attempted to use the @docusaurus/plugin-ideal-image plugin, and found it wasn't compressing images in a development enviroment. I needed to do a production build for it to compress images, so I wanted to add a note to the docs so other developers don't get confused like me.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Check for spelling and grammar.

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Apr 9, 2020

Deploy preview for docusaurus-2 ready!

Built with commit 1963c48

https://deploy-preview-2572--docusaurus-2.netlify.com

Copy link
Contributor

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is as if self-evident, but LGTM.

@yangshun yangshun requested a review from wgao19 as a code owner April 10, 2020 02:46
@yangshun yangshun changed the title Add a note that plugin-ideal-image only perform compression on a production build docs(v2): mention that plugin-ideal-image only perform compression on a production build Apr 10, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think notes are a bit overkill for this, so I modified the description of the plugin instead.

@yangshun yangshun merged commit a8ab0d6 into facebook:master Apr 10, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants