Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): hide doc sidebar on mobiles #2631

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Apr 20, 2020

Motivation

It really came as a result of tiny refactoring #2595.

Although I would still notice this bug before the new release, so no reason for concern 👌.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before After
image image

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Apr 20, 2020
@lex111 lex111 added this to the v2.0.0-alpha.51 milestone Apr 20, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 20, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 48353eb

https://deploy-preview-2631--docusaurus-2.netlify.app

@yangshun yangshun merged commit 2823d73 into master Apr 20, 2020
@lex111 lex111 deleted the lex111/hide-sidebar-mobile branch April 20, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants