Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v2): bump webpack-dev-server to 3.11.0 to address yargs vulnerability #2728

Merged

Conversation

taylorreece
Copy link
Contributor

Motivation

webpack-dev-server fixed their dependency on yargs-parser, which had a vulnerability. This PR bumps Docusaurus' webpack-dev-server dependency to 3.11.0, so it pulls in that vulnerability patch. webpack/webpack-dev-server#2566

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I verified yarn test and yarn start still work as expected.

Related PRs

webpack/webpack-dev-server#2566

@taylorreece taylorreece requested a review from yangshun as a code owner May 8, 2020 16:23
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 8, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit 7efd906

https://deploy-preview-2728--docusaurus-2.netlify.app

@yangshun yangshun changed the title Bumped webpack-dev-server to 3.11.0 to address yargs vulnerability chore(v2): bump webpack-dev-server to 3.11.0 to address yargs vulnerability May 8, 2020
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yangshun yangshun merged commit dc08f3b into facebook:master May 8, 2020
@lex111 lex111 added this to the v2.0.0-alpha.55 milestone May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants